[Bug 36693] New: Improve floating toolbar in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Bug ID: 36693 Summary: Improve floating toolbar in OPAC search results Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org I think the floating toolbar ( #floating ) can be slightly improved. -Between the #toolbar and the .selections-toolbar there is a small space and one can see the content beneath it. Slight annoyance -I think we can use position: sticky now to accomplish the "floating". It seems to have widespread enough support: https://caniuse.com/?search=sticky -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165488&action=edit Bug 36693: Remove hc-sticky and use CSS sticky To test: 1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. DO an OPAC search that has enough results to scroll. 3. The toolbar which includes pagination, select all, clear all, etc. should scoll the same as it did without the patch. 4. There should no longer be a small gap between the pagination and the other tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- I took care of the removal of HC stick in Bug 36694. I will use this one to remove the small gap that you can see through in the #floating element. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 [Bug 36694] Remove HC Sticky library in favor of CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |ASSIGNED --- Comment #3 from David Nind <david@davidnind.com> --- Changed status to assigned, as there is nothing to sign off yet 8-). I can confirm the behavour mentioned in current main - a small space and can see the content beneath it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165768&action=edit Bug 36693: Add background color to OPAC floating element To test: 1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. DO an OPAC search that has enough results to scroll. 3. There should no longer be a small gap between the pagination and the other tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165768|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 165795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165795&action=edit Bug 36693: Add background color to OPAC floating element To test: 1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. DO an OPAC search that has enough results to scroll. 3. There should no longer be a small gap between the pagination and the other tools. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |BLOCKED --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Dependency in FQA state, marking as blocked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Dependency is pushed to main. Setting this one to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Does this issue still exist in main? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Needs Signoff |RESOLVED --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #8)
Does this issue still exist in main?
It doesn't appear so. I cant track down where it was fixed, maybe during Bootstrap 5 updates? Either way, I'll close this report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Bug 36693 depends on bug 36694, which changed state. Bug 36694 Summary: Remove HC Sticky library in favor of CSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org