[Bug 37188] New: Batch patron modification from report results broken in 24.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Bug ID: 37188 Summary: Batch patron modification from report results broken in 24.05 Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: hebah@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: run a report using borrowernumber as one of the columns. Select batch actions from visible results. See that batch patron modification is not an option. Confirmed change in behavior from 23.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Are you *sure* that's a change from 23.11? Bug 29181 made the decision to show patron card creator when you select borrowernumber, and to show batch patron modification when you select cardnumber, and thus to only show both when you select borrowernumber, cardnumber, and that bug says it landed in 23.11 so it should be a change from 23.05 to 23.11. Certainly a regression in 24.05 that batch patron modification is broken since bug 34478 broke sending things to it by changing it from a POST which it accepts to a GET which it does not, though. Filed bug 37197 for that -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37197 [Bug 37197] Batch patron modification from reports fails by using GET instead of POST -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Bug 29181 comment 2 in the commit message said "The logic of the dropdown menu has been modified in order to ensure that duplicate patron modification options aren't shown in the menu when a report return both borrowernumber and cardnumber" but I don't see why that would occur. Batch patron modification can take either borrowernumber or cardnumber, so we should show it IF show_cardnumber_ops || show_borrowernumber_ops while patron card creator can only take borrowernumber so we should only show it IF show_borrowernumber_ops, and then if you select cardnumber you get batch patron modification only, if you select borrowernumber you get both, if you select both you get both. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Oh, not quite so simple, since we have to know which sort of data we are sending to batch mod, and have a way to send it the thing we have from a particular report. Still, if ( (borrowernumber and cardnumber) or (borrowernumber and !cardnumber)) batchmod_borrowernumber elseif (cardnumber) batchmod_cardnumber endif if (cardnumber) cardcreator_cardnumber isn't *that* messy. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch patron modification |Batch patron modification |from report results broken |from report results should |in 24.05 |be an option when | |borrowernumber is selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- *** Bug 37479 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169612&action=edit Bug 37188: Allow batch modification of borrowers from reports with cardnumber or borrowernumber Some libraries do not use cardnumbers for their patrons, but would still like to be able to batch modify patrons from reports. Borrowernumber is going to be authoritative - every borrower will have one - so if this column is included in the results we should offer batch modification. If we have cardnumber, we can use that. If we have both, we should use borrowernumber To test: 1 - Write a report like: SELECT cardnumber FROM borrowers ORDER BY rand() LIMIT 35 2 - Run report 3 - Click "Batch operations.." -> "Batch patron modification" 4 - Confirm it works 5 - Edit report: SELECT borrowernumber FROM borrowers ORDER BY rand() LIMIT 35 6 - Run report 7 - No option for batch modifying patrons 8 - Apply patch 9 - Run report 10 - The option for batch modificatoin now shows 11 - Confirm both batch operation types work from report 12 - Edit report: SELECT cardnumber,borrowernumber FROM borrowers ORDER BY rand() LIMIT 35 13 - Run report 14 - Confirm both batch operations work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169612|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 169726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169726&action=edit Bug 37188: Allow batch modification of borrowers from reports with cardnumber or borrowernumber Some libraries do not use cardnumbers for their patrons, but would still like to be able to batch modify patrons from reports. Borrowernumber is going to be authoritative - every borrower will have one - so if this column is included in the results we should offer batch modification. If we have cardnumber, we can use that. If we have both, we should use borrowernumber To test: 1 - Write a report like: SELECT cardnumber FROM borrowers ORDER BY rand() LIMIT 35 2 - Run report 3 - Click "Batch operations.." -> "Batch patron modification" 4 - Confirm it works 5 - Edit report: SELECT borrowernumber FROM borrowers ORDER BY rand() LIMIT 35 6 - Run report 7 - No option for batch modifying patrons 8 - Apply patch 9 - Run report 10 - The option for batch modificatoin now shows 11 - Confirm both batch operation types work from report 12 - Edit report: SELECT cardnumber,borrowernumber FROM borrowers ORDER BY rand() LIMIT 35 13 - Run report 14 - Confirm both batch operations work Signed-off-by: Laura ONeil <laura@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169726|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169814&action=edit Bug 37188: Allow batch modification of borrowers from reports with cardnumber or borrowernumber Some libraries do not use cardnumbers for their patrons, but would still like to be able to batch modify patrons from reports. Borrowernumber is going to be authoritative - every borrower will have one - so if this column is included in the results we should offer batch modification. If we have cardnumber, we can use that. If we have both, we should use borrowernumber To test: 1 - Write a report like: SELECT cardnumber FROM borrowers ORDER BY rand() LIMIT 35 2 - Run report 3 - Click "Batch operations.." -> "Batch patron modification" 4 - Confirm it works 5 - Edit report: SELECT borrowernumber FROM borrowers ORDER BY rand() LIMIT 35 6 - Run report 7 - No option for batch modifying patrons 8 - Apply patch 9 - Run report 10 - The option for batch modificatoin now shows 11 - Confirm both batch operation types work from report 12 - Edit report: SELECT cardnumber,borrowernumber FROM borrowers ORDER BY rand() LIMIT 35 13 - Run report 14 - Confirm both batch operations work Signed-off-by: Laura ONeil <laura@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Keywords|regression | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if this is a regression really - I believe it was only cardnumber from the beginning when this feature was implemented. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Bug 37188 depends on bug 37197, which changed state. Bug 37197 Summary: Batch patron modification from reports fails by using GET instead of POST https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37197 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Some libraries do not use release notes| |card numbers for their | |patrons, but would still | |like to be able to batch | |modify patrons from | |reports. This will makes it | |so that adding the | |borrowernumber to a report | |will also allow to trigger | |batch patron modifications. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 [Bug 40937] No option to show/hide data menu in report results when including borrowernumber -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org