[Bug 13836] New: Koha/Number/Price.pm: format_for_editing fails 3 tests because of leading spaces in output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Bug ID: 13836 Summary: Koha/Number/Price.pm: format_for_editing fails 3 tests because of leading spaces in output Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org # Failed test 'format_for_editing should return unformated integer part with 2 decimals' # at t/Prices.t line 610. # got: ' 1234567.00' # expected: '1234567.00' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marc, they pass ok for me: prove t/Prices.t t/Prices.t .. ok All tests successful. Files=1, Tests=16, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.59 cusr 0.05 csys = 0.68 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 --- Comment #2 from Marc Véron <veron@veron.ch> --- Hi Katrin, See my results below. Maybe related to Number::Format? cpan -D Number::Format Installed: 1.73 CPAN: 1.73 up to date http://search.cpan.org/~wrw/Number-Format-1.73/Format.pm Koha version 3.19.00.016 Perl version 5.014002 ------------ prove t/Prices.t t/Prices.t .. 1/16 # Failed test 'format_for_editing should return unformated integer part with 2 decimals' # at t/Prices.t line 610. # got: ' 1234567.00' # expected: '1234567.00' # Failed test 'format_for_editing should return unformated integer part with 2 decimals' # at t/Prices.t line 611. # got: ' 1234567.89' # expected: '1234567.89' # Failed test 'format_for_editing should return unformated integer part with 2 decimals' # at t/Prices.t line 610. # got: ' 1234567.00' # expected: '1234567.00' # Failed test 'format_for_editing should return unformated integer part with 2 decimals' # at t/Prices.t line 611. # got: ' 1234567.89' # expected: '1234567.89' # Looks like you failed 4 tests of 16. t/Prices.t .. Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/16 subtests Test Summary Report ------------------- t/Prices.t (Wstat: 1024 Tests: 16 Failed: 4) Failed tests: 13-16 Non-zero exit status: 4 Files=1, Tests=16, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.35 cusr 0.18 csys = 0.55 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marc, I have the same version. What is your locale setting? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 --- Comment #4 from Marc Véron <veron@veron.ch> --- Hi Katrin, # dpkg -l locales ||/ Name Version Architektur Beschreibung +++-==============-============-============-================================= ii locales 2.13-38+deb7 all Embedded GNU C Library: National # locale LANG=de_CH.UTF-8 LANGUAGE=de_CH:de LC_CTYPE="de_CH.UTF-8" LC_NUMERIC="de_CH.UTF-8" LC_TIME="de_CH.UTF-8" LC_COLLATE="de_CH.UTF-8" LC_MONETARY="de_CH.UTF-8" LC_MESSAGES="de_CH.UTF-8" LC_PAPER="de_CH.UTF-8" LC_NAME="de_CH.UTF-8" LC_ADDRESS="de_CH.UTF-8" LC_TELEPHONE="de_CH.UTF-8" LC_MEASUREMENT="de_CH.UTF-8" LC_IDENTIFICATION="de_CH.UTF-8" LC_ALL= -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 --- Comment #5 from Marc Véron <veron@veron.ch> --- With de_DE.UTF-8 *) tests pass OK What impact have locales on Koha? Could there be bugs related to locales? *) # locale LANG=de_DE.UTF-8 LANGUAGE=de_CH:de LC_CTYPE="de_DE.UTF-8" LC_NUMERIC="de_DE.UTF-8" LC_TIME="de_DE.UTF-8" LC_COLLATE="de_DE.UTF-8" LC_MONETARY="de_DE.UTF-8" LC_MESSAGES="de_DE.UTF-8" LC_PAPER="de_DE.UTF-8" LC_NAME="de_DE.UTF-8" LC_ADDRESS="de_DE.UTF-8" LC_TELEPHONE="de_DE.UTF-8" LC_MEASUREMENT="de_DE.UTF-8" LC_IDENTIFICATION="de_DE.UTF-8" LC_ALL= -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's the Number::Price that might be a bit specific here - adding Jonathan to the bug report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36932&action=edit Bug 13836: Does not separate symbol and value if symbol is not displayed. This patch force the separation between the symbol and the value to an empty string if the symbol is not displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 36934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36934&action=edit [Signed-off] Bug 13836: Does not separate symbol and value if symbol is not displayed. This patch force the separation between the symbol and the value to an empty string if the symbol is not displayed. Tested with locale de_CH.UTF-8, prove t/Prices.t is now successful. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36932|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36934|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36937&action=edit [PASSED QA] Bug 13836: Does not separate symbol and value if symbol is not displayed. This patch force the separation between the symbol and the value to an empty string if the symbol is not displayed. Tested with locale de_CH.UTF-8, prove t/Prices.t is now successful. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org