[Bug 31183] New: Add Koha::Item::Transfers->filter_by_current
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Bug ID: 31183 Summary: Add Koha::Item::Transfers->filter_by_current Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30447 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 [Bug 30447] pendingreserves.pl is checking too many transfers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137851&action=edit Bug 31183: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137852&action=edit Bug 31183: Add Koha::Item::Transfers->filter_by_current This patch introduces the aforementioned method. To test: 1. Apply this unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item/Transfers.t => FaIL: method not defined? 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137853&action=edit Bug 31183: Use filter_by_current in Koha::Holds->get_items_that_can_fill This patch makes the method use the new Koha::Item::Transfers->filter_by_current one. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137851|0 |1 is obsolete| | --- Comment #4 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137944&action=edit Bug 31183: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137852|0 |1 is obsolete| | --- Comment #5 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137945&action=edit Bug 31183: Add Koha::Item::Transfers->filter_by_current This patch introduces the aforementioned method. To test: 1. Apply this unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item/Transfers.t => FaIL: method not defined? 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137853|0 |1 is obsolete| | --- Comment #6 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137946&action=edit Bug 31183: Use filter_by_current in Koha::Holds->get_items_that_can_fill This patch makes the method use the new Koha::Item::Transfers->filter_by_current one. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Michal Urban <michalurban177@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137944|0 |1 is obsolete| | Attachment #137945|0 |1 is obsolete| | Attachment #137946|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138887&action=edit Bug 31183: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138888&action=edit Bug 31183: Add Koha::Item::Transfers->filter_by_current This patch introduces the aforementioned method. To test: 1. Apply this unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item/Transfers.t => FaIL: method not defined? 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138889&action=edit Bug 31183: Use filter_by_current in Koha::Holds->get_items_that_can_fill This patch makes the method use the new Koha::Item::Transfers->filter_by_current one. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Michal Urban <michalurban177@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Shouldn't we use it from Koha::Item->get_transfers as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #10)
Shouldn't we use it from Koha::Item->get_transfers as well?
Yes! I forgot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31328 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31328 [Bug 31328] Make Koha::Item->get_transfer* use Koha::Item::Transfers->filter_by_current -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Bug 31183 depends on bug 30447, which changed state. Bug 30447 Summary: pendingreserves.pl is checking too many transfers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org