[Bug 9751] New: Patron flags red in moremember.pl like in circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Bug ID: 9751 Summary: Patron flags red in moremember.pl like in circulation.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In a patron detail page (moremember.pl), when looking at a patron with one or more flags, for example : . Patron is restricted until 30/03/2013 (debarr comment) . Patron's address is in doubt. . Patron's card has been reported lost. Click on Check out tab and look at circulation page : flags are red. It is more attractive for librarian. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15903&action=edit Proposed patch See commit comment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15904&action=edit screen-shot with patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15903|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15986&action=edit Bug 9751: Patron flags red in moremember.pl like in circulation.pl In a patron detail page (moremember.pl), when looking at a patron with one or more flags. Click on Check out tab and look at circulation page : flags are red. It is more attractive for librarian. This patch add CSS classes to patron flags in moremember.pl so they look more like circulation.pl : - red color - custom list bullets Test plan ; - Set to a patron all flags. - Go to detail page of this patron => Check all flags are red and bullets are like ">" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16494&action=edit Check out tab for a patron with flags set -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16495&action=edit Details tab for a patron with flags set The patch is an improvement, as it makes the flags display more consistent, but there are still some differences I wanted to show with those 2 screenshots. Passing QA on this as it is an improvement :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15986|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16496&action=edit [PASSED QA] Bug 9751: Patron flags red in moremember.pl like in circulation.pl In a patron detail page (moremember.pl), when looking at a patron with one or more flags. Click on Check out tab and look at circulation page : flags are red. It is more attractive for librarian. This patch add CSS classes to patron flags in moremember.pl so they look more like circulation.pl : - red color - custom list bullets Test plan ; - Set to a patron all flags. - Go to detail page of this patron => Check all flags are red and bullets are like ">" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch makes display more consistent and passes all tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off Patch complexity|Trivial patch |--- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org