https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50248&action=edit Bug 16263: making authority tags and subfields actions buttons To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50274&action=edit Menu gets cut off if browser window isn't very wide Could you switch <ul class="dropdown-menu pull-left" to <ul class="dropdown-menu pull-right" ? That would keep the menu from popping up off the page in cases where the browser window isn't at least 1520px wide or so. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Arslan Farooq <arslanone@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arslanone@gmail.com --- Comment #4 from Arslan Farooq <arslanone@gmail.com> --- We need to make <ul class="dropdown-menu pull-left" to <ul class="dropdown-menu pull-right" at line 167 as Owen pointed out. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- The latest patch removes "pull-right" from authtypes.tt but doesn't add it to auth_tag_structure.tt. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 --- Comment #9 from Arslan Farooq <arslanone@gmail.com> --- Hi, The patch works fine. Everything looks OK. However the qa tools fails. It says: http://paste.koha-community.org/419 Note: I made sure master branch was up to date. And tested the patch on a fresh checked out branch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Arslan Farooq <arslanone@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50274|0 |1 is obsolete| | Attachment #50671|0 |1 is obsolete| | Assignee|aleishaamohia@hotmail.com |arslanone@gmail.com Status|Needs Signoff |Failed QA --- Comment #11 from Arslan Farooq <arslanone@gmail.com> --- Created attachment 50705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50705&action=edit Bug 16263: making authority tags and subfields actions buttons After applying patch, everything looked OK in staff client. But the QA tools are complaining about something: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt OK forbidden patterns SKIP spelling OK tt_valid FAIL valid_template Attempt to reload Koha/Template/Plugin/Koha.pm aborted. Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206. OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|arslanone@gmail.com |aleishaamohia@hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about the "i" symbol for showing the subfields list - why not use the "eye" as we have in other places? Thanks for fixing 'subfields' - that was bugging me since forever! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50705|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50773&action=edit Bug 16263: making authority tags and subfields actions buttons EDIT: Subfields icon, 'i' to eye To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq <arslanone@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50773|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 50781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50781&action=edit [SIGNED-OFF] Bug 16263: making authority tags and subfields actions buttons EDIT: Subfields icon, 'i' to eye To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Another sign, pretty eye. No errors. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50781|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50787&action=edit [PASSED QA] Bug 16263: making authority tags and subfields actions buttons EDIT: Subfields icon, 'i' to eye To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Another sign, pretty eye. No errors. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.