[Bug 10256] New: Remove some unused subs from Overdues module, or do not export them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Bug ID: 10256 Summary: Remove some unused subs from Overdues module, or do not export them Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: m.de.rooy@rijksmuseum.nl Reporter: m.de.rooy@rijksmuseum.nl CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Did a grep on the following exported subs: CreateItemAccountLine UpdateAccountLines CheckAccountLineLevelInfo CheckAccountLineItemInfo CheckExistantNotifyid GetNextIdNotify GetNotifyId ReplacementCost ReplacementCost2 GetOverdueDelays GetOverduerules As it appears, they are not even used anywhere (anymore). My proposal is now to remove them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18165&action=edit Bug 10256: Remove some unused subs from Overdues module Removes the following exported but unused subs from Overdues.pm: CreateItemAccountLine UpdateAccountLines CheckAccountLineLevelInfo CheckAccountLineItemInfo CheckExistantNotifyid GetNextIdNotify GetNotifyId ReplacementCost ReplacementCost2 GetOverdueDelays GetOverduerules Test plan: It is hard to test the removal of something that was not used :) Try this: Do a recursive grep on these routine names in the Koha codebase. Compile some scripts that use the Overdues module. And just to be sure we do not break something: Go to Circulation: Do a checkout, checkin, place and confirm a hold. Go to Patrons: Goto Check out. Goto Fines. Run the command line scripts: fines.pl and overdue_notices.pl. Go to opac-user.pl. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10021 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, I think this is related to a bug I filed - only I was concentrating on the database relicts that are connected to those subs: bug 10021 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #2)
I think this is related to a bug I filed - only I was concentrating on the database relicts that are connected to those subs: bug 10021
Good catch, Katrin. Well, this patch could remove the first code. Your report is somewhat broader in scope. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove some unused subs |Remove some unused subs |from Overdues module, or do |from Overdues module |not export them | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18165|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18765&action=edit Bug 10256: Remove some unused subs from Overdues module Removes the following exported but unused subs from Overdues.pm: CreateItemAccountLine UpdateAccountLines CheckAccountLineLevelInfo CheckAccountLineItemInfo CheckExistantNotifyid GetNextIdNotify GetNotifyId ReplacementCost ReplacementCost2 GetOverdueDelays GetOverduerules Test plan: It is hard to test the removal of something that was not used :) Try this: Do a recursive grep on these routine names in the Koha codebase. Compile some scripts that use the Overdues module. And just to be sure we do not break something: Go to Circulation: Do a checkout, checkin, place and confirm a hold. Go to Patrons: Goto Check out. Goto Fines. Run the command line scripts: fines.pl and overdue_notices.pl. Go to opac-user.pl. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Small patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I did not find any occurrence of these routines using git grep. So we can suppose that this patch remove unused code and will not break something. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18765|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18978&action=edit Bug 10256: Remove some unused subs from Overdues module Removes the following exported but unused subs from Overdues.pm: CreateItemAccountLine UpdateAccountLines CheckAccountLineLevelInfo CheckAccountLineItemInfo CheckExistantNotifyid GetNextIdNotify GetNotifyId ReplacementCost ReplacementCost2 GetOverdueDelays GetOverduerules Test plan: It is hard to test the removal of something that was not used :) Try this: Do a recursive grep on these routine names in the Koha codebase. Compile some scripts that use the Overdues module. And just to be sure we do not break something: Go to Circulation: Do a checkout, checkin, place and confirm a hold. Go to Patrons: Goto Check out. Goto Fines. Run the command line scripts: fines.pl and overdue_notices.pl. Go to opac-user.pl. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org