[Bug 13416] New: Typo in marc21_leader.pl position 5 (record status)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Bug ID: 13416 Summary: Typo in marc21_leader.pl position 5 (record status) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Instead of a space in the leader on this position, it should be an a. Trivial fix forthcoming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 34217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34217&action=edit Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: Use the popup to set position 5 to a (increase in encoding level). Check if this patch puts an a in that position of the leader. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 34446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34446&action=edit Bug 13416: Follow-up fix whitespace issues First patch failed koha qa tests due to white space issues. This patch corrects it. TEST PLAN --------- 1) Apply first patch 2) run koha qa test tools -- fails line 19 and 21 3) apply this patch 4) run koha qa test tools -- passes I'll leave this as needing sign off, just so that Marcel can confirm this patch is good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34217|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 34447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34447&action=edit [SIGNED OFF] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34446|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 34448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34448&action=edit Bug 13416: Follow-up fix whitespace issues First patch failed koha qa tests due to white space issues. This patch corrects it. TEST PLAN --------- 1) Apply first patch 2) run koha qa test tools -- fails line 19 and 21 3) apply this patch 4) run koha qa test tools -- passes I'll leave this as needing sign off, just so that Marcel can confirm this patch is good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34447|0 |1 is obsolete| | Attachment #34448|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 34452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34452&action=edit Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks, Mark. Caused by a tab. When I apply it again, it gets converted into spaces, and the second patch is no longer needed (and not working anymore). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34452|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34520&action=edit [PASSED QA] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- String changes, held for 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Version|master |3.16 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 --- Comment #12 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org