[Bug 25787] New: Club holds can't be placed without modify_holds_priority permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Bug ID: 25787 Summary: Club holds can't be placed without modify_holds_priority permission Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: george@nekls.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Staff cannot place a request for a patron club if the staff member does not have modify_holds_priority set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- That's no good. I've also found that staff can't see the button for the tools page if the clubs is the only tool they have permission too. But that is a different bug. This definitely needs to be fixed. I don't like loop holes in permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org --- Comment #2 from Jason Robb <jrobb@sekls.org> --- Still valid in 21.11.11. Technically place_holds is also required to get that far so it may be that the overarching reserveforothers permission is what's truly required to successfully place a club hold. The ability to place club holds should really be its own separate user permission nested under the reserveforothers (or possibly clubs?) permission group. In our club usage scenario, a mistaken club hold can lead to hundreds of a holds on a record which puts many items in motion to patrons that don't actually want them. I wrote some JS to hide the "Clubs" tab at request.pl with exception for the select staff users in charge of placing club holds. It also changes the label wording from "Search patrons or clubs" to just "Search patrons". var loggedUser = $("#logged-in-info-full .loggedinusername").text(); var clubbers = ["staffusername1", "staffusername2"]; //show for these users if ($.inArray(loggedUser, clubbers) == -1) { $('#circ_request [href="#holds_clubsearch_pane"]').closest('li').hide(); $('#circ_request label:contains("Search patrons or clubs")').text("Search patrons"); } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |21.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 trevor.diamond@mainlib.org changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |24.05 CC| |trevor.diamond@mainlib.org --- Comment #3 from trevor.diamond@mainlib.org --- This bizarre requirement is still around in 24.05. I had to ask around to even figure out this permission was related as the name and the function we're attempting to do (place club holds) aren't related on the surface. If it happens to be fixed in 24.11 I will come back and update this bug (I'll find out in June 2025) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Trevor, commenting on the bug and confirming it#s still an issue in a current version is very helpful. I can't promise you a fix, but I'll highlight it in the list on the dashboard with my keyword. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- As George suggested, the API route expects full reserveforothers api/v1/swagger/paths/clubs.yaml: 94 x-koha-authorization: 95 permissions: 96 reserveforothers: "1" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 179633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179633&action=edit Bug 25787: Update club holds to only require place_holds permission This moves the permission check from top level to the specific place_hold permission To test: 1 - Create a club 2 - Enroll some patrons 3 - Find or create a staff user with 'place_holds' permission and catalogue permission 4 - Log in as that staff 5 - Find a book and go to holds tab' 6 - Search for your club 7 - Try to place hold 8 - Nothing happens FIXME we should alert of the 403 error or other 9 - Apply patch, yanr build, restart_all 10 - Place hold 11 - Success! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Partial patch attached, needs unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 ayoung <ayoung@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ayoung@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181831&action=edit Bug 25787: Add unit tests prove -v t/db_dependent/api/v1/clubs_holds.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179633|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 181841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181841&action=edit Bug 25787: Update club holds to only require place_holds permission This moves the permission check from top level to the specific place_hold permission To test: 1 - Create a club 2 - Enroll some patrons 3 - Find or create a staff user with 'place_holds' permission and catalogue permission 4 - Log in as that staff 5 - Find a book and go to holds tab' 6 - Search for your club 7 - Try to place hold 8 - Nothing happens FIXME we should alert of the 403 error or other 9 - Apply patch, yanr build, restart_all 10 - Place hold 11 - Success! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181831|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 181842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181842&action=edit Bug 25787: Add unit tests prove -v t/db_dependent/api/v1/clubs_holds.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes placing holds release notes| |for clubs. Placing holds | |for a club now only | |requires the place_holds | |permission. --- Comment #11 from David Nind <david@davidnind.com> --- One thing I noticed on the holds page (before and after the patch) is that the autocomplete for the club ID or partial name on the holds page doesn't work for me. Most likely, another bug that needs fixing! Testing notes (suing KTD): 1. To enroll patrons in a club: 1.1 Go to a patron's page in the staff interface 1.2 On either their check out or details page, select the "Clubs" tab 1.3 Click "Enroll" action to enroll them in the club -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k CC| |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181841|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181985&action=edit Bug 25787: Update club holds to only require place_holds permission This moves the permission check from top level to the specific place_hold permission To test: 1 - Create a club 2 - Enroll some patrons 3 - Find or create a staff user with 'place_holds' permission and catalogue permission 4 - Log in as that staff 5 - Find a book and go to holds tab' 6 - Search for your club 7 - Try to place hold 8 - Nothing happens FIXME we should alert of the 403 error or other 9 - Apply patch, yanr build, restart_all 10 - Place hold 11 - Success! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181842|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181986&action=edit Bug 25787: Add unit tests prove -v t/db_dependent/api/v1/clubs_holds.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Passing QA here. (In reply to Jason Robb from comment #2)
The ability to place club holds should really be its own separate user permission nested under the reserveforothers (or possibly clubs?) permission group.
This is a valid point, and likely worth to open a follow-up bug for it (enhancement). (In reply to David Nind from comment #11)
One thing I noticed on the holds page (before and after the patch) is that the autocomplete for the club ID or partial name on the holds page doesn't work for me.
Most likely, another bug that needs fixing!
I also noticed this, but I'm not sure it's a bug. I think it's a feature that's missing! I may be wrong, but it appears this club input was not designed to have autocomplete in the first place! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority |additional_work_needed --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #14)
Passing QA here.
(In reply to Jason Robb from comment #2)
The ability to place club holds should really be its own separate user permission nested under the reserveforothers (or possibly clubs?) permission group.
This is a valid point, and likely worth to open a follow-up bug for it (enhancement).
(In reply to David Nind from comment #11)
One thing I noticed on the holds page (before and after the patch) is that the autocomplete for the club ID or partial name on the holds page doesn't work for me.
Most likely, another bug that needs fixing!
I also noticed this, but I'm not sure it's a bug. I think it's a feature that's missing! I may be wrong, but it appears this club input was not designed to have autocomplete in the first place!
Can you please open the bugs mentioned here? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this broke the test on D12: t_db_dependent_api_v1_clubs_holds_t Can you please double check and provide a fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #17)
I believe this broke the test on D12:
t_db_dependent_api_v1_clubs_holds_t
Can you please double check and provide a fix?
I can't reproduce this failure locally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this one here is another candidate: 15:52:20 koha_1 | # Looks like you failed 1 test of 3. 15:52:20 koha_1 | [13:50:45] t/db_dependent/api/v1/clubs_holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #20 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Can't reproduce this failure locally either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39869 [Bug 39869] Club holds API missing tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed the club related tests now it looks like! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39872 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39873 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 --- Comment #22 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #15)
(In reply to Pedro Amorim from comment #14)
Passing QA here.
(In reply to Jason Robb from comment #2)
The ability to place club holds should really be its own separate user permission nested under the reserveforothers (or possibly clubs?) permission group.
This is a valid point, and likely worth to open a follow-up bug for it (enhancement).
(In reply to David Nind from comment #11)
One thing I noticed on the holds page (before and after the patch) is that the autocomplete for the club ID or partial name on the holds page doesn't work for me.
Most likely, another bug that needs fixing!
I also noticed this, but I'm not sure it's a bug. I think it's a feature that's missing! I may be wrong, but it appears this club input was not designed to have autocomplete in the first place!
Can you please open the bugs mentioned here? Thanks!
Bugs created: 1. Bug 39873 - Patron club holds - separate permission for ability to place club holds 2. Bug 39872 - Patron club holds - autocomplete does not work as expected (like patron name autocomplete) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not impact 24.11 LTS on permission behavior for stability -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org