[Bug 5211] New: marking lost (long overdue) not charging fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Summary: marking lost (long overdue) not charging fines Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 It used to be that if you manually marked an item as Long Overdue (Lost) it would automatically charge the patron the replacement price for the item. This is not happening now unless you use the cron job to mark things long overdue and lost. It should happen in both instances. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #1 from Melia Meggs <melia@bywatersolutions.com> 2011-11-30 00:56:48 UTC --- Nicole, is this still a problem, or was it fixed with Bug 5533? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |srdjan@catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-12-02 00:36:30 UTC --- Created attachment 6500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6500 patch Modified the LostItem() subroutine to take a "charge" parameter, and altered any usage of that subroutine to pass said param (to maintain consistency). That'll lay some of the groundwork while we get the larger issue of the admin interface worked out. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Needs Signoff |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-02 13:13:07 UTC --- Adds necessary new param to subroutine, and changes all calls to LostItem to pass this, so behaviour remains unchanged. Opens doors for later fixes to "lost" logic. Marking as Signed off and Passed QA in one go. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-03 06:20:07 UTC --- Before pushing, a question: I don't understand why we need a 3rd parameter in the LostItem sub. Is there a case where we don't want to add fines when marking an item lost ? After applying the patch I can't find a call without this parameter. So, I feel the parameter is not needed and add useless complexity to the API. Other question: can we now mark LostItem and forgive fine ? I feel no (which is not a problem, just to be sure) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-03 06:39:06 UTC --- I think there are some scenarios where you don't want to charge the fine immediately. For example: Claims returned. In this case the library normally searches for the book on its shelves to make sure there was not something missed on return. If the book can not be found, the patron will be charged for the item later on. I don't think Koha works like that right now, but with the parameter we could treat different lost status differently again. If I understand it correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-03 14:13:19 UTC --- Paul, I've asked this to be done based on requests from NEKLS and VOKAL (two of ByWater's large consortia). When bug 5533 was incorporated, it changed the semantics of the various "lost" statuses. Before, certain values would do different things, depending on what triggered them. Some libraries like this, and came to depend on it. In my opinion, an Authorized Value shouldn't be any more than a label on it's own; there is not mechanism for defining any additional actions or meaning at the AV level. But, marking something as "lost" is more than just labeling it. As of right now, it means always charging the patron for the material and sometimes returning it (if it's checked out). This patch will allow for us to sometimes charge and sometimes return. Right now, there is no change in functionality with this patch, but this opens those doors for us down the road. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 10:38:14 UTC --- Ian & Katrin, thanks for your answers. patch now pushed, please test Also, please open another bug (ENH ?) to suggest the improved behaviour (let one choose to apply fine or not) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5211 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org