[Bug 13379] New: authorised_values.category is varchar(16)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Bug ID: 13379 Summary: authorised_values.category is varchar(16) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org But borrower_attribute_types is varchar(10). So if you try to link a patron attribute type with an AV category with a length
10, the link won't be done.
Also, I propose to extend this field to varchar(32). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34089&action=edit Bug 13379: Extends authorised_values.category to varchar(32) This patch does 2 things: 1/ It fixes a bug caused by the different data fields used for authorised_values.category and borrower_attribute_types.authorised_value_category (varchar(16) vs varchar(10)). To reproduce: - Create a AV category with a length > 10 - Try to link a patron attribute type with this AV, it won't work. 2/ Extends this field to varchar(32): sometime 16 is not enough to describe something -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34089|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 34132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34132&action=edit [SIGNED-OFF] Bug 13379: Extends authorised_values.category to varchar(32) This patch does 2 things: 1/ It fixes a bug caused by the different data fields used for authorised_values.category and borrower_attribute_types.authorised_value_category (varchar(16) vs varchar(10)). To reproduce: - Create a AV category with a length > 10 - Try to link a patron attribute type with this AV, it won't work. 2/ Extends this field to varchar(32): sometime 16 is not enough to describe something Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors. Error reproduced, fixed by patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13380 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34132|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34143&action=edit [PASSED QA] Bug 13379: Extends authorised_values.category to varchar(32) This patch does 2 things: 1/ It fixes a bug caused by the different data fields used for authorised_values.category and borrower_attribute_types.authorised_value_category (varchar(16) vs varchar(10)). To reproduce: - Create a AV category with a length > 10 - Try to link a patron attribute type with this AV, it won't work. 2/ Extends this field to varchar(32): sometime 16 is not enough to describe something Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors. Error reproduced, fixed by patch. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a note: aqbudgets.sort1_authcat and aqbudgets.sort2_authcat wre both varchar(80) - so there is another mismatch, although it should not cause any trouble. Not sure if we should shrink it to match and if so, we should do it on another bug). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15069 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org