[Bug 7338] New: link to serial detail wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Bug #: 7338 Summary: link to serial detail wrong Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/serials/serials-collection.pl?subscripti onid=5427 OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Serials AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com Created attachment 6672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6672 subscription # links When on this page: /cgi-bin/koha/serials/serials-collection.pl?subscriptionid=5427 if you click the serial # at the top it takes you to the detail which I think is right. But if you click the serial # next to the issue history it just refreshes the page you're on. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-09 06:38:44 UTC --- Created attachment 6688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6688 screenshot of record with more than 1 subscription and manipulated URL It's a scoping problem, but I made an interesting find: http://localhost:8080/cgi-bin/koha/serials/serials-collection.pl?biblionumbe... If you have more than one subscription for that record and you add the biblionumber of the subscription to the URL instead of the subscriptionid, you get an overview of your entire serial collection for that record. Why do we never link this page like this? Am I missing something? Will send a patch to fix the scoping problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-09 06:45:05 UTC --- Created attachment 6689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6689 Bug 7338: Link on serial collection page wrong This was a scoping error. The links are not supposed to show up when you open that page with a subscription id in the URL. To test: 1) Check links don't show up now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-12-09 07:35:27 UTC --- Created attachment 6690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6690 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6690|0 |1 is patch| | Attachment #6690|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-12-09 17:50:57 UTC --- Why are there two patches? I'm going to test the first one which was Katrin's -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6689|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-12-09 17:52:32 UTC --- Created attachment 6695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6695 [SIGNED-OFF] Bug 7338: Link on serial collection page wrong This was a scoping error. The links are not supposed to show up when you open that page with a subscription id in the URL. To test: 1) Check links don't show up now. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Signed Off AssignedTo|colin.campbell@ptfs-europe. |katrin.fischer@bsz-bw.de |com | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-12-09 17:53:14 UTC --- Signed off on Katrin's patch. Please let me know what the second patch was for. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-09 18:11:07 UTC --- I think Frederic and me discovered a hidden feature while trying to fix this bug. I will try to investigate / test it a bit more this weekend. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6695|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-12 07:46:43 UTC --- Created attachment 6713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6713 Bug 7338: Follow up: show link only when there is more than 1 subscription To be tested together with http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6690 1) Create a subscription for a title - check the link 'Show any subscription...' doesn't show now - check the serials collection page works correctly and shows all necessary information 2) Create a second subscription for the same title - check a new link 'Show any subscription...' shows up now - use links in the issue table to change between viewing the single subscription and the overview page - check it works correctly and all information shows up -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-12 07:47:52 UTC --- Hi Nicole, sorry for causing confusion and thx for your sign-off. Could you take a look at those both patches together? It should make available some nice new functionality for records with more than 1 subscription! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6713|0 |1 is obsolete| | --- Comment #10 from Frédéric Demians <frederic@tamil.fr> 2011-12-12 09:02:20 UTC --- Created attachment 6717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6717 Signed-off follow-up patch It works. With this patch, on Serials Collection page, the link, 'See any subscription attached to this biblio' appears only when there are more than one subscription attached to the biblio record. Kait: You haven't attach my patch with your sign-off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-12 09:09:46 UTC --- Hi Frederic, thx for signing off. Your patch works great as well - I will replace the attached patch with a signed off one tonight. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6690|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-13 07:19:40 UTC --- Created attachment 6733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6733 [SIGNED-OFF] Bug 7338 Links on Serial Collection page Don't display link to the serial, when the collection page displays just one subscription. Display it when several subscriptions. Alway display a link for displaying biblio record other subscriptions. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely, but always shows link to 'any subscriptions'. I did a follow-up so the link would only show if there was more than 1 subscription for the record. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #13 from Ian Walls <ian.walls@bywatersolutions.com> 2012-01-05 13:20:13 UTC --- Works as advertised, template-based change (with a bit of logic in the script to send new param values). Patches must be applied in REVERSE ORDER than currently listed. Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-06 14:16:30 UTC --- patch pushed please test: QA comment: prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Pushed to Master |Pushed to Stable -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org