[Bug 36762] New: Item not transferred correctly when there is a pending hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Bug ID: 36762 Summary: Item not transferred correctly when there is a pending hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Koha is doing some dumb stuff when one attempts to transfer an item that could fill a pending hold. To recreate: 1 - be logged in at Branch A 2 - have a bib with 1 holdable item at Branch A 3 - place a hold for pickup at Branch B 4 - confirm hold shows on Holds to Pull and Holds Queue 5 - go to Circulation > Transfers and attempt to send your item to Branch C 6 - Koha gives you three options. Pick the first one: "Transfer to Branch B." This is the hold pickup branch, not the branch you selected for your transfer 7 - Koha tells you it has transferred the item to Branch C (the branch you did select for your transfer) 8 - go to detail.pl for your title, confirm the holdings table says "there is an item level hold" on your item 9 - click to the Holds tab for your title, confirm the hold claims to be in transit 10 - query the branchtransfers table, confirm no transfer was created 11 - query reserves and confirm your hold has found=T, itemnumber=[your item], and item_level_hold=0 12 - Back on the title, attempt to revert transit status, confirm the Revert button doesn't do anything At step 6, Koha should offer to transfer to the indicated transfer-target, rather than the hold pickup branch. Then it should actually generate the transfer and should not insert the itemnumber into the reserves table or update reserves.found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not sure if this is the same problem but some items at our branch A with a hold for pickup at branch B are not transferred when checking them in at A and clicking Confirm hold and transfer. Note that the hold is updated to a transit hold (found==T) but no transfer is made. Nothing to be found in the logfiles either. Most items go well. No clue yet which conditions must be met to trigger the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #1)
Not sure if this is the same problem but some items at our branch A with a hold for pickup at branch B are not transferred when checking them in at A and clicking Confirm hold and transfer. Note that the hold is updated to a transit hold (found==T) but no transfer is made. Nothing to be found in the logfiles either.
Most items go well. No clue yet which conditions must be met to trigger the issue.
This is in 22.11 btw -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not so sure if I could reproduce my issue on master btw. Master added several actions like cud-checkin and cud-affect-reserve in the CSRF changes, which seem to impact the flow here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37650 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #1)
Not sure if this is the same problem but some items at our branch A with a hold for pickup at branch B are not transferred when checking them in at A and clicking Confirm hold and transfer. Note that the hold is updated to a transit hold (found==T) but no transfer is made. Nothing to be found in the logfiles either.
Most items go well. No clue yet which conditions must be met to trigger the issue.
Found this issue. It is a separate bug on itself. See bug 37650 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Anni Rajala <anni.rajala@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anni.rajala@turku.fi --- Comment #5 from Anni Rajala <anni.rajala@turku.fi> --- This would be nice to get fixed. It is good that the user is alarmed about existing holds, but user should be able to either transfer the item to the indicated transfer-target or decide not to make the transfer at all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Brenda <bowens@washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bowens@washoecounty.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Katariina Pohto <katariina.pohto@ouka.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katariina.pohto@ouka.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #6 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- *** Bug 40056 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Andrew Fuerste-Henry from comment #0)
Koha is doing some dumb stuff when one attempts to transfer an item that could fill a pending hold. To recreate:
1 - be logged in at Branch A 2 - have a bib with 1 holdable item at Branch A 3 - place a hold for pickup at Branch B 4 - confirm hold shows on Holds to Pull and Holds Queue 5 - go to Circulation > Transfers and attempt to send your item to Branch C 6 - Koha gives you three options. Pick the first one: "Transfer to Branch B." This is the hold pickup branch, not the branch you selected for your transfer 7 - Koha tells you it has transferred the item to Branch C (the branch you did select for your transfer) 8 - go to detail.pl for your title, confirm the holdings table says "there is an item level hold" on your item 9 - click to the Holds tab for your title, confirm the hold claims to be in transit 10 - query the branchtransfers table, confirm no transfer was created 11 - query reserves and confirm your hold has found=T, itemnumber=[your item], and item_level_hold=0 12 - Back on the title, attempt to revert transit status, confirm the Revert button doesn't do anything
At step 6, Koha should offer to transfer to the indicated transfer-target, rather than the hold pickup branch. Then it should actually generate the transfer and should not insert the itemnumber into the reserves table or update reserves.found.
I'm able to reproduce this expect step 12:
12 - Back on the title, attempt to revert transit status, confirm the Revert button doesn't do anything
Did you mean "Revert transit status" button in holds table or am I missing something here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmi Takkinen from comment #7)
(In reply to Andrew Fuerste-Henry from comment #0)
Koha is doing some dumb stuff when one attempts to transfer an item that could fill a pending hold. To recreate:
1 - be logged in at Branch A 2 - have a bib with 1 holdable item at Branch A 3 - place a hold for pickup at Branch B 4 - confirm hold shows on Holds to Pull and Holds Queue 5 - go to Circulation > Transfers and attempt to send your item to Branch C 6 - Koha gives you three options. Pick the first one: "Transfer to Branch B." This is the hold pickup branch, not the branch you selected for your transfer 7 - Koha tells you it has transferred the item to Branch C (the branch you did select for your transfer) 8 - go to detail.pl for your title, confirm the holdings table says "there is an item level hold" on your item 9 - click to the Holds tab for your title, confirm the hold claims to be in transit 10 - query the branchtransfers table, confirm no transfer was created 11 - query reserves and confirm your hold has found=T, itemnumber=[your item], and item_level_hold=0 12 - Back on the title, attempt to revert transit status, confirm the Revert button doesn't do anything
At step 6, Koha should offer to transfer to the indicated transfer-target, rather than the hold pickup branch. Then it should actually generate the transfer and should not insert the itemnumber into the reserves table or update reserves.found.
I'm able to reproduce this expect step 12:
12 - Back on the title, attempt to revert transit status, confirm the Revert button doesn't do anything
Did you mean "Revert transit status" button in holds table or am I missing something here?
Ah, of course you meant "Revert transit status" button, I just can't read :D Although for me using "Revert transit status" did "revert" transit status even though there really wasn't any transfer generated to branchtransfers table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- At least setting variable $ignoreRs as 1 doesn't work logically. Code block for elsif ( $op eq "cud-SetTransit" ) where variable is set is called _after_ selecting clicking "Transfer to Branch B.". Clicking "Transfer" button in form calls "cud-transfer" block and Koha attempts to create transfer. When "Transfer to.." is then clicked, "cud-transfer" is never called again and no transit is actually made. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 --- Comment #10 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 199238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199238&action=edit Bug 36762: Fix setting transfer for hold via branchtransfers.pl When one tries to transfer an item that could fill a pending hold to a library that is not the holds pickup library, Koha gives only a option to transfer item to pickup library. When this option is chosen, Koha tells that item is being transfered to selected library not to pickup library but fails to create the transfer. This patch fixes this by setting op variable as "cud-transfer" and tobranchcd as holds pickup library so that transfer is actually made and target library is displaued correctly. To test: 1. Log into Library A. 2. Find or create a biblio with 1 holdable item at Library A. 3. Place a hold for pickup at Library B. 4. Navigate to Circulation > Transfers. 5. Attempt to send your item to Library C. 6. Koha gives you three options. Pick the first one: "Transfer to Library B." 7. Koha tells you it has transferred the item to Library C. 8. Go to detail.pl for your title, confirm the holdings table says "there is an item level hold" on your item. 9. Click to the Holds tab for your title, confirm the hold claims to be in transit. 10. Query the branchtransfers table SELECT * FROM branchtransfers WHERE itemnumber = [your item] => Note that no new transfer was made. 11. Query reserves SELECT * FROM reserves WHERE biblionumber = [your biblio] => Confirm your hold has found=T, itemnumber=[your item], and item_level_hold=0 12. Revert trasfer from biblios holds page. 13. Apply this patch. 14. Attempt the transfer again. => Koha should now tell that transfer was made to Libary B. 15. Check branchtransfers table again. => New transfer should have been made to Library B. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 --- Comment #11 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 199239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199239&action=edit Bug 36762: Allow to ignore hold when creating a transfer When one tries to transfer an item that could fill a pending hold to a library that is not the holds pickup library, Koha gives only a option to transfer item to pickup library. This patch adds new option to ignore hold and transfer item to the library user selected in transfer tool. To test: 1. Log into Library A. 2. Find or create a biblio with 1 holdable item at Library A. 3. Place a hold for the biblio with pickup at Library B. 4. Navigate to Circulation > Transfers. 5. Attempt to transfer item to Library C. => Note that Koha only allows to transfer item to Library B, cancel hold and attempt transfer or return to the transfer tool. 6. Apply this patch. 7. Attempt to transfer item again. => Note that there is now an option to ignore the hold and transfer item to Library C. => When option to transfer item to the Library C is selected, confirm that Koha tells that transfer was made to Library C and a new transfer was made to database. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #12 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- There are two problem here, transfer for hold isn't made (patch 1) and there is no option to ignore hold and transfer item somewhere else as Andrew suggested (patch 2). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199239|0 |1 is obsolete| | --- Comment #13 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 199594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199594&action=edit Bug 36762: Allow to ignore hold when creating a transfer When one tries to transfer an item that could fill a pending hold to a library that is not the holds pickup library, Koha gives only a option to transfer item to pickup library. This patch adds new option to ignore hold and transfer item to the library user selected in transfer tool. To test: 1. Log into Library A. 2. Find or create a biblio with 1 holdable item at Library A. 3. Place a hold for the biblio with pickup at Library B. 4. Navigate to Circulation > Transfers. 5. Attempt to transfer item to Library C. => Note that Koha only allows to transfer item to Library B, cancel hold and attempt transfer or return to the transfer tool. 6. Apply this patch. 7. Attempt to transfer item again. => Note that there is now an option to ignore the hold and transfer item to Library C. => When option to transfer item to the Library C is selected, confirm that Koha tells that transfer was made to Library C and a new transfer was made to database. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #14 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Fixed a error in last patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | CC| |david@davidnind.com --- Comment #15 from David Nind <david@davidnind.com> --- Added assignee 8-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Koha-Suomi Oy list of Sponsors| | Status|Needs Signoff |Signed Off Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 199725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199725&action=edit Bug 36762: Fix setting transfer for hold via branchtransfers.pl When one tries to transfer an item that could fill a pending hold to a library that is not the holds pickup library, Koha gives only a option to transfer item to pickup library. When this option is chosen, Koha tells that item is being transfered to selected library not to pickup library but fails to create the transfer. This patch fixes this by setting op variable as "cud-transfer" and tobranchcd as holds pickup library so that transfer is actually made and target library is displaued correctly. To test: 1. Log into Library A. 2. Find or create a biblio with 1 holdable item at Library A. 3. Place a hold for pickup at Library B. 4. Navigate to Circulation > Transfers. 5. Attempt to send your item to Library C. 6. Koha gives you three options. Pick the first one: "Transfer to Library B." 7. Koha tells you it has transferred the item to Library C. 8. Go to detail.pl for your title, confirm the holdings table says "there is an item level hold" on your item. 9. Click to the Holds tab for your title, confirm the hold claims to be in transit. 10. Query the branchtransfers table SELECT * FROM branchtransfers WHERE itemnumber = [your item] => Note that no new transfer was made. 11. Query reserves SELECT * FROM reserves WHERE biblionumber = [your biblio] => Confirm your hold has found=T, itemnumber=[your item], and item_level_hold=0 12. Revert trasfer from biblios holds page. 13. Apply this patch. 14. Attempt the transfer again. => Koha should now tell that transfer was made to Libary B. 15. Check branchtransfers table again. => New transfer should have been made to Library B. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 199726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199726&action=edit Bug 36762: Allow to ignore hold when creating a transfer When one tries to transfer an item that could fill a pending hold to a library that is not the holds pickup library, Koha gives only a option to transfer item to pickup library. This patch adds new option to ignore hold and transfer item to the library user selected in transfer tool. To test: 1. Log into Library A. 2. Find or create a biblio with 1 holdable item at Library A. 3. Place a hold for the biblio with pickup at Library B. 4. Navigate to Circulation > Transfers. 5. Attempt to transfer item to Library C. => Note that Koha only allows to transfer item to Library B, cancel hold and attempt transfer or return to the transfer tool. 6. Apply this patch. 7. Attempt to transfer item again. => Note that there is now an option to ignore the hold and transfer item to Library C. => When option to transfer item to the Library C is selected, confirm that Koha tells that transfer was made to Library C and a new transfer was made to database. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes two issues when release notes| |transferring an item that | |could fill a pending hold | |to a library that is not | |the holds pickup library: | |1. Koha only gives you an | |option to transfer the item | |to the pickup library. When | |this option is chosen, Koha | |says that item is being | |transferred to the selected | |library, not to the pickup | |library. Then it fails to | |create the transfer. | |2. Adds a new option | |("Ignore hold and transfer | |to [Library name]") to | |ignore the hold and | |transfer the item to the | |library selected in the | |transfer tool. --- Comment #18 from David Nind <david@davidnind.com> --- I attempted a release note, please fix up any mistakes or improve 8-). I know this is a library workflow issue, but why would you want to transfer the item to a library different from where it was selected for pickup? (Or perhaps I am misunderstanding the issue!) Testing notes (using KTD): 1. I used the interactive mode when applying the patches, working through the first patch "Fix setting transfer for hold via branchtransfers.pl", then the second patch. 2. Settings used for testing patches: - Library A = Centerville - Library B = Midway - Library C = Fairview - Record used: Programming Perl (292) with one item 39999000011418 (578) - Patron used: Mary Burton (Midway) 3. After the first patch, I: - Cancelled the transit (Revert transit status) from the record's holds page - Then deleted the hold (delete icon on the same page) - Changed the library to Midway - Cancelled the transfer on Circulation > Transfers > Transfers to receive - Changed the library back to Centerville - Item should now be shown as available again -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org