[Bug 10359] New: CCSR theme should apply jqTransform after OpacUserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Bug ID: 10359 Summary: CCSR theme should apply jqTransform after OpacUserJS Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: jcamins@cpbibliography.com Reporter: jcamins@cpbibliography.com Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 18419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18419&action=edit Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $("select[name='idx']").append("<option value='Host-item,wrdl'>Journal title</option>"); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18419|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 18440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18440&action=edit Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $("select[name='idx']").append("<option value='Host-item,wrdl'>Journal title</option>"); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Just move a js line some lines before. No regression possible. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18440|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18451&action=edit Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $("select[name='idx']").append("<option value='Host-item,wrdl'>Journal title</option>"); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org