[Bug 32061] New: <span> in the title of z39.50 servers page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Bug ID: 32061 Summary: <span> in the title of z39.50 servers page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When accessing the Z39.50 servers page, in the title of the page (what appears in the browser tab) there are html tags <span>. To test: 1. Go to Administration > Z39.50/SRU servers 2. Click "New Z39.50 server" --> Notice in the browser tab, the title of the page is New <span>Z39.50</span> server > ... It does this for new Z39.50 server, new SRU server and when editing a server too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143978&action=edit Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers In another bug we added spans to ease translations in the PROCESS block for server types. This PROCESS is used in several places, but only creates a problem when used in the title. The patch removes the spans using the remove TT filter avoiding having to change the PROCESS and causing a string change. To test: * Go to administration > Z39.50/SRU servers * Add a new Z39.50 and a SRU server or look at the form * The page title in the browser tab will show the span * Same for editing an existing Z39.50 or SRU server * Apply the patch * Verify the page titles are now correct Hint: you can see the full page title when hovering on the tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143978|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 144024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144024&action=edit Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers In another bug we added spans to ease translations in the PROCESS block for server types. This PROCESS is used in several places, but only creates a problem when used in the title. The patch removes the spans using the remove TT filter avoiding having to change the PROCESS and causing a string change. To test: * Go to administration > Z39.50/SRU servers * Add a new Z39.50 and a SRU server or look at the form * The page title in the browser tab will show the span * Same for editing an existing Z39.50 or SRU server * Apply the patch * Verify the page titles are now correct Hint: you can see the full page title when hovering on the tab. Signed-off-by: David <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144024|0 |1 is obsolete| | --- Comment #3 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 144041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144041&action=edit Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers In another bug we added spans to ease translations in the PROCESS block for server types. This PROCESS is used in several places, but only creates a problem when used in the title. The patch removes the spans using the remove TT filter avoiding having to change the PROCESS and causing a string change. To test: * Go to administration > Z39.50/SRU servers * Add a new Z39.50 and a SRU server or look at the form * The page title in the browser tab will show the span * Same for editing an existing Z39.50 or SRU server * Apply the patch * Verify the page titles are now correct Hint: you can see the full page title when hovering on the tab. Signed-off-by: David <david@davidnind.com> Signed-off-by: hammat <hammat@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144041|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144612&action=edit Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers In another bug we added spans to ease translations in the PROCESS block for server types. This PROCESS is used in several places, but only creates a problem when used in the title. The patch removes the spans using the remove TT filter avoiding having to change the PROCESS and causing a string change. To test: * Go to administration > Z39.50/SRU servers * Add a new Z39.50 and a SRU server or look at the form * The page title in the browser tab will show the span * Same for editing an existing Z39.50 or SRU server * Apply the patch * Verify the page titles are now correct Hint: you can see the full page title when hovering on the tab. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Hammat Wele <hammat@inlibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.01 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33551 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org