[Bug 13586] New: Makefile.PL mentions win32
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Bug ID: 13586 Summary: Makefile.PL mentions win32 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: katrin.fischer@bsz-bw.de, rochellehealy.student@wegc.school.nz, the.invinnysible.one@gmail.com Depends on: 13570 Whilst working on Bug #13570, Katrin spotted that MSWin32 is also still mentioned within the makefile.. we should also clean it up in there :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #1 from Rochelle Healy <rochellehealy.student@wegc.school.nz> --- Created attachment 35318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35318&action=edit Bug 13586: Makefile.PL mentions win32 Edited Makefile.PL to remove mentions of win32 To test: Run Makefile.PL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Rochelle Healy <rochellehealy.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 35318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35318 Bug 13586: Makefile.PL mentions win32 Review of attachment 35318: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13586&attachment=35318) ----------------------------------------------------------------- ::: Makefile.PL @@ -1481,4 @@
unless exists $skip_directories->{$key}; } } - elsif ($^O eq 'MSWin32' ) { # On Win32, the install probably needs to be done under the user account koha will be running as...
What's done in this block should be removed too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35947&action=edit Bug 13586: Remove the entire block Previous patch remove the condition but not the block tested. The entire block should be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35948&action=edit Bug 13586: Remove some other occurrences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35318|0 |1 is obsolete| | Attachment #35947|0 |1 is obsolete| | Attachment #35948|0 |1 is obsolete| | --- Comment #5 from Larry Baerveldt <larry@bywatersolutions.com> --- Created attachment 36697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36697&action=edit [SIGNED OFF] Bug 13586: Makefile.PL mentions win32 Edited Makefile.PL to remove mentions of win32 To test: Run Makefile.PL Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #6 from Larry Baerveldt <larry@bywatersolutions.com> --- Created attachment 36698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36698&action=edit [SIGNED OFF] Bug 13586: Remove the entire block Previous patch remove the condition but not the block tested. The entire block should be removed. Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #7 from Larry Baerveldt <larry@bywatersolutions.com> --- Created attachment 36699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36699&action=edit [SIGNED OFF] Bug 13586: Remove some other occurrences Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36697|0 |1 is obsolete| | Attachment #36698|0 |1 is obsolete| | Attachment #36699|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36907&action=edit [PASSED QA] Bug 13586: Makefile.PL mentions win32 Edited Makefile.PL to remove mentions of win32 To test: Run Makefile.PL Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36908&action=edit [PASSED QA] Bug 13586: Remove the entire block Previous patch remove the condition but not the block tested. The entire block should be removed. Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36909&action=edit [PASSED QA] Bug 13586: Remove some other occurrences Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Rochele! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.9 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org