[Bug 14249] New: discharge letter edits
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Bug ID: 14249 Summary: discharge letter edits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The discharge letter says 'his' regardless of gender. We should probably reword it so that it's clear. Also it uses the library's code instead of name and probably most people wouldn't know the library code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 39364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39364&action=edit letter image -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nicole, I offer to write the patch, but can you write the text for me? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14251 CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Something like either of these: <heading>Discharge Confirmation</heading> <right>TODAYS DATE</right> BRANCH NAME certifies that the following borrower: FIRSTNAME SURNAME, Cardnumber: CARDNUMBER currently has no items checked out. Or <heading>Discharge Confirmation</heading> <right>TODAYS DATE</right> BRANCH NAME certifies that the following borrower: FIRSTNAME SURNAME, Cardnumber: CARDNUMBER has returned all items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39936&action=edit Bug 14249: Improve sample discharge letter (en) Improves formatting and wording as suggested by Nicole on bug 14249. To test: - Activate UseDischarge - Request a discharge from a patron account in the OPAC - Confirm discharge from the start page of the staff interface - Download PDF from the patron account in the OPAC - Verify the displayed text is formatted and reads correctly 06/06/2015 15:18 Discharge confirmation Midway certifies that the following borrower: Firstname surname (cardnumber: 1) has returned all items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Summary|discharge letter edits |Improve discharge letter | |sample notice --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nicole, could you check the attached changes are ok? Once the English text is ok, I will write a patch for the translated installers as well. I didn't manage to change the text alignment with embedded CSS - not sure how this can be done. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39936|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 40327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40327&action=edit [SIGNED-OFF] Bug 14249: Improve sample discharge letter (en) Improves formatting and wording as suggested by Nicole on bug 14249. To test: - Activate UseDischarge - Request a discharge from a patron account in the OPAC - Confirm discharge from the start page of the staff interface - Download PDF from the patron account in the OPAC - Verify the displayed text is formatted and reads correctly 06/06/2015 15:18 Discharge confirmation Midway certifies that the following borrower: Firstname surname (cardnumber: 1) has returned all items. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Messages is Ok, no errors I think you cant modify message using embeded CSS, html -> pdf procedure ignores CSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40327|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40407&action=edit [PASSED QA] Bug 14249: Improve sample discharge letter (en) Improves formatting and wording as suggested by Nicole on bug 14249. To test: - Activate UseDischarge - Request a discharge from a patron account in the OPAC - Confirm discharge from the start page of the staff interface - Download PDF from the patron account in the OPAC - Verify the displayed text is formatted and reads correctly 06/06/2015 15:18 Discharge confirmation Midway certifies that the following borrower: Firstname surname (cardnumber: 1) has returned all items. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Messages is Ok, no errors I think you cant modify message using embeded CSS, html -> pdf procedure ignores CSS. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Installation and upgrade | |(web-based installer) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org