[Bug 18175] New: Makefile sets koha-httpd api path incorrectly for standard installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Bug ID: 18175 Summary: Makefile sets koha-httpd api path incorrectly for standard installs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: alex.sassmannshausen@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org When performing a standard (or single) install, Makefile.PL generates an koha-httpd.conf with a hardcoded ../api/$1/app.pl reference. This error causes all REST api routes to fail in a standard/single install context. GET fails with 404, PUT fails with 403. The hard-coded path is correct in the dev context. Switching from an Apache variable to a Makefile variable, and hence replacing the hardcoded ../api bit of the path should fix this. Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 --- Comment #1 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 60700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60700&action=edit Bug 18175: Use Makefile variable for api path. * etc/koha-httpd.conf: Use __API_CGI_DIR__ instead of %{DOCUMENT_ROOT}/../api. Test plan: Confirming the problem: - Do a standard install of Koha - Test any REST API route. - The route will error out. Confirming the resolution: - Apply this patch. - Do a standard install of Koha - Test any REST API route. - The route will work. Confirming no regression: - Apply this patch. - Do a dev install of Koha - Test any REST API route. - The route will work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.sassmannshausen@ptfs-e |ity.org |urope.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | Component|Web services |REST api CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexbuckley@catalyst.net.nz --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi there Sorry this patch is not applying cleanly on master (as the below output shows), can you please either rebase the patch or define the Koha version this patch should be used on? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18175: Use Makefile variable for api path. Using index info to reconstruct a base tree... M etc/koha-httpd.conf Falling back to patching base and 3-way merge... Auto-merging etc/koha-httpd.conf CONFLICT (content): Merge conflict in etc/koha-httpd.conf Failed to merge in the changes. Patch failed at 0001 Bug 18175: Use Makefile variable for api path. The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18175-Use-Makefile-variable-for-api-path-cy4MsZ.patch Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.sassmannshausen@gmail. |martin.renvoize@ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I 'think' this problem has gone away now.. going to mark as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #3)
I 'think' this problem has gone away now.. going to mark as resolved.
I think we fixed it with https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21031 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org