http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|rel_3_8 |master Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |fcapovilla@live.ca --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11826|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11829&action=edit Bug 8687: Improvements in the overdue_notices.pl script - UTF-8 support in the HTML output - Add the cardnumber and phone columns to the csv output Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Add 2 field for the csv output (cardnumber and phone) and add the utf8 support for the html output. Seems good. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: sorry, but this patch introduces a perlcritic error: I/O layer ":utf8" used at line 367, column 5. Use ":encoding(UTF-8)" to get strict validation. (Severity: 5) (before your patch there is also: "require" statement with library name as string at line 29, column 12. Use a bareword instead. (Severity: 5) which is still here after the patch, not a problem -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 --- Comment #8 from wajasu <matted-34813@mypacks.net> --- Created attachment 12404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12404&action=edit Bug-8667-cleaned-up-perlcritic-complaints-aligned-usage with POD doc fixed perlcritic, tested with email, -html, -html 'odue' i see: title;name;surname;address1;address2;zipcode;city;email;itemcount;itemsinfo;due_date;issue_date in my emails, and think that probably needs to get restricted to only csv requests. maybe 6030 will address that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11829|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12711&action=edit Bug-8667 cleaned up perlcritic complaints, aligned usage with POD doc http://bugs.koha-community.org/show_bug.cgi?id=8687 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12713&action=edit Bug-8667 cleaned up perlcritic complaints, aligned usage with POD doc http://bugs.koha-community.org/show_bug.cgi?id=8687 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: wajasu: we don't want to delete the BEGIN bloc. Could you resubmit your last patch with reintroduce it please ? QA's rules had change :) Now we accept the eval { require "$FindBin::Bin/../kohalib.pl" }; (see the discussion on koha-devel: [QA] 2 short QA questions) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |pelletiermaxime@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17601|0 |1 is obsolete| | --- Comment #15 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 17941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17941&action=edit Improvements in the overdue_notices.pl script (new version) Sending a new version of the patch to corrects some errors. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #16 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 8687: Improvements in the overdue_notices.pl script Using index info to reconstruct a base tree... M misc/cronjobs/overdue_notices.pl Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/overdue_notices.pl CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl Patch failed at 0001 Bug 8687: Improvements in the overdue_notices.pl script The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17941|0 |1 is obsolete| | --- Comment #17 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 23150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23150&action=edit Improvements in overdue_notices.pl script (Newer version) Here is a new, updated version of the script based on the current master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #18 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Before the patch: name;surname;address1;address2;zipcode;city;country;email;itemcount;itemsinfo bébé;saby;"15 rie";;;;;math.saby_15@gmail.com;1;"22/11/2013 Palladio 013559A Lionello Puppi 2273 " thefirstname;thename;"rue X";"batiment 2";75000;PARIS;France;;1;"22/11/2013 Souvenirs d'enfance et de jeunesse 125305F Ernest Renan 2272 " mathieu;saby;;;;;;math.saby_15@gmail.com;1;"07/11/2013 Lecture de Valéry2 0281972092 par James R. Lawler 2301 " After the patch: name;surname;address1;address2;zipcode;city;country;email;phone;cardnumber;itemcount;itemsinfo;branchname;letternumber bébé;saby;"15 rie";;;;;math.saby_15@gmail.com;;6;1;"2273 29/11/2013 22/11/2013 Palladio 013559A Lionello Puppi W 11246 BU centrale ";"BU centrale";1 thefirstname;thename;"rue X";"batiment 2";75000;PARIS;France;;060606060606;3;1;"2272 29/11/2013 22/11/2013 Souvenirs d'enfance et de jeunesse 125305F Ernest Renan 605634 BU centrale ";"BU centrale";1 mathieu;saby;;;;;;math.saby_15@gmail.com;;1;1;"2301 29/11/2013 07/11/2013 Lecture de Valéry2 0281972092 par James R. Lawler 606395 BU centrale ";"BU centrale";3 It seems ok. Except there seems to be an extra linefeed before the closing " of the item information (but it was an existing bug before your patch). Regarding UTF-8 : I tried to put chinese text in my notices, and to generate it before your patch. Chinese text is displayed properly. After your patch also, but I don't see any change. Is utf8 display of notices broken in current master? I sign off, as this patch improves overdue_notices.pl without breaking anything. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hello Frédérick, Your patch modify the value of itemcontent, is it intentional? I don't think it is a good idea to change this default value. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am stumbling over this bug report again and again, wondering what it is about as the subject is not really telling much. After reading the comments I think this would have been a bit better as 2 separate bug reports, one for the CSV and one for the HTML output change. I agree with Jonathan about the change to the itemscontent default as this would be an unexpected change for a lot of libraries. Also itemnumber and branchname are not useful for a lot of libraries. -my $itemscontent = join( ',', qw( date_due title barcode author itemnumber ) ); +my $itemscontent = join( ',', qw( itemnumber issuedate date_due title barcode author itemcallnumber branchname ) ); It looks like this is hiding a 3rd feature even: +SELECT biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue, branchname + FROM issues,items,biblio, biblioitems, branches b Making ist possible to put the branchname instead of the branchcode into the output of items? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23229|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Simith, I see that Kyle passed QA on this, but could you maybe reattach a patch with a commit message? A short description of what this patch changes/adds to the script? I think this has gone quite a long way since the beginning so most of the comments here do no longer apply. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please provide a step by step test plan and a summary of the changes/consequences of your patch. There are hints in the wiki about how to write the 'good' commit message: http://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30451|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30873&action=edit Bug 8687 - Overdues: Add utf-8 support to HTML and additional fields to CSV output This patch contains small improvements made in the overdue_notices.pl script. - UTF-8 support in the HTML output - Add the phone, cardnumber, branchname and letternumber columns to the csv output Testing: I) Create an issue overdue (intranet): 0) Enter in a patron account, add some characters like ユーザー別サイト in his address 1) Check if in Patron category administration the overdue column is YES for his code 2) In Tools -> Notice triggers define first delay = 7, letter Overdue notice. Nothing for second ni third 3) Check if Tools -> Notices and slips, code overdue is available 4) checkout a book with a retard more than 7 days. 5) Check if Adminstration -> Defining circulation and fine rules for all libraries has fine rules for his patron category, item type book. II) Before applying the patch 0) Run misc/cronjobs/overdue_notices.pl -n -html . 1) Open the file notices_"date".html in a brower 2) Validate the characters are not correct III) After applying the patch 0) Run misc/cronjobs/overdue_notices.pl -n -html . 1) Open the file notices_"date".html in a brower 2) Validate the characters are correct 3) Run misc/cronjobs/overdue_notices.pl -n -csv temp.csv 4) Validate phone, cardnumber, branchname and letternumber columns and values Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30873|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30874&action=edit Bug 8687 - Overdues: Add utf-8 support to HTML and additional fields to CSV output This patch contains small improvements made in the overdue_notices.pl script. - UTF-8 support in the HTML output - Add the phone, cardnumber, branchname and letternumber columns to the csv output Testing: I) Create an issue overdue (intranet): 0) Enter in a patron account, add some characters like ユーザー別サイト in his address 1) Check if in Patron category administration the overdue column is YES for his code 2) In Tools -> Notice triggers define first delay = 7, letter Overdue notice. Nothing for second ni third 3) Check if Tools -> Notices and slips, code overdue is available 4) checkout a book with a retard more than 7 days. 5) Check if Adminstration -> Defining circulation and fine rules for all libraries has fine rules for his patron category, item type book. II) Before applying the patch 0) Run misc/cronjobs/overdue_notices.pl -n -html . 1) Open the file notices_"date".html in a brower 2) Validate the characters are not correct III) After applying the patch 0) Run misc/cronjobs/overdue_notices.pl -n -html . 1) Open the file notices_"date".html in a brower 2) Validate the characters are correct 3) Run misc/cronjobs/overdue_notices.pl -n -csv temp.csv 4) Validate phone, cardnumber, branchname and letternumber columns and values Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed a conflict with some patches recently pushed - I have problems getting the overdues working currently - CSV only has the header line and no other entries. I will try again later if I can get this to cooperate. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.