[Bug 31007] New: Can't save a supplement issue with mandatory subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 Bug ID: 31007 Summary: Can't save a supplement issue with mandatory subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 29496 fixed new issues mandatory subfields check. But there is still a problem with a supplement issue with mandatory subfields. I it nearly the same code missing class "input_marceditor" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 [Bug 29496] Can't save an order with mandatory items subfields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |johanna.raisa@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like it is the only one missing :
git grep '<select .*name="field_value"' koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt: <select name="field_value" class="input_marceditor"> koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt: <select name="field_value" class="select2 input_marceditor"> koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt: <select name="field_value"> koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt: <select name="field_value" class="input_marceditor">
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136405&action=edit Bug 29496: (follow-up) fix for supplemental issues The select field validation fails for supplemental issues in serials-edit.tt. Test plan inspired from Bug 29496 : Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Click to add item" below "Supplemental issue" and fill the item form that appears. 6- Click on "Save" 7- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 8- Apply the patch 9- Repeat step 3 to 6 10- Check that no error appear and that your item has been created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136406&action=edit Bug 31007: Fix CheckMandatorySubfields with select fields for supplement issue The select field validation fails for supplemental issues in serials-edit.tt. Test plan inspired from Bug 29496 : Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Click to add item" below "Supplemental issue" and fill the item form that appears. 6- Click on "Save" 7- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 8- Apply the patch 9- Repeat step 3 to 6 10- Check that no error appear and that your item has been created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136405|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136406|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136407&action=edit Bug 31007: Fix CheckMandatorySubfields with select fields for supplement issue The select field validation fails for supplemental issues in serials-edit.tt. Test plan inspired from Bug 29496 : Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Click to add item" below "Supplemental issue" and fill the item form that appears. 6- Click on "Save" 7- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 8- Apply the patch 9- Repeat step 3 to 6 10- Check that no error appear and that your item has been created https://bugs.koha-community.org/show_bug.cgi?id=31007 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I knew this one looked familiar, now I found out why, I had Signed Off the exact same patch a little earlier: bug 30658. Which one to pick? I can sign off here... but Janusz was a little earlier. *** This bug has been marked as a duplicate of bug 30658 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org