[Bug 37371] New: Direct input of dates not working when editing dates manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Bug ID: 37371 Summary: Direct input of dates not working when editing dates manually Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Find a any date picker in Koha, like DOB in the patron record. 2. Add a date, either manually or using the date picker. 3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 4. The date easily becomes malformed. I searched for bugs related to this with Maskito. Unfortunatly I think the Maskito libray and feature needs to be removed. See Bug 33703 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33703 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 [Bug 33703] Entering dates should be more flexible accepting different entry formats -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Direct input of dates not |Direct input of dates not |working when editing dates |working when editing only |manually |part of a date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- So the Maskito mark works fine in dateaccessioned.pl plugin on additem.tt, so I think something in calendar.inc may be causing the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am updating severity as this is also an accessibility issue. The direct input is much easier than using the calendar widget for some. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Could you catch me and demo what you're seeing Lucas? I just tried and I can't get the date to malform but maybe I'm not seeing what you are. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169083&action=edit Bug 37371: Move Maskito instantiation to onReady -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 169085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169085&action=edit Bug 37371: Set overwrite mode to replace In our case I think overwriteMode needs to be set to replace: https://maskito.dev/core-concepts/overwrite-mode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 169086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169086&action=edit Bug 37371: Move Maskito init to onReady in dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169086|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 169087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169087&action=edit Bug 37371: Move Maskito init to onReady in dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 169088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169088&action=edit Bug 37371: Move Maskito instantiation to onReady ( OPAC ) To test: 1. Find a any date picker in Koha, like DOB in the patron record. 2. Add a date, either manually or using the date picker. 3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 4. The date easily becomes malformed. 5. APPLY PATCHSET, maybe clear your browser cache too 6. Try directly inputing dates. I would suggest the following places: -Patron record DOB -Specify due date on circ/circulation.pl as this includes time -Add item screen, this is the dateaccessioned plugin -OPAC self reg/self modify -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Thank you Martin for figuring this one out! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169083|0 |1 is obsolete| | Attachment #169085|0 |1 is obsolete| | Attachment #169087|0 |1 is obsolete| | Attachment #169088|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169094&action=edit Bug 37371: Move Maskito instantiation to onReady ( OPAC ) To test: 1. Find a any date picker in Koha, like DOB in the patron record. 2. Add a date, either manually or using the date picker. 3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 4. The date easily becomes malformed. 5. APPLY PATCHSET, maybe clear your browser cache too 6. Try directly inputing dates. I would suggest the following places: -Patron record DOB -Specify due date on circ/circulation.pl as this includes time -Add item screen, this is the dateaccessioned plugin -OPAC self reg/self modify Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169094|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169135&action=edit Bug 37371: Move Maskito instantiation to onReady Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169136&action=edit Bug 37371: Set overwrite mode to replace In our case I think overwriteMode needs to be set to replace: https://maskito.dev/core-concepts/overwrite-mode Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169137&action=edit Bug 37371: Move Maskito init to onReady in dateaccessioned.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169138&action=edit Bug 37371: Move Maskito instantiation to onReady ( OPAC ) To test: 1. Find a any date picker in Koha, like DOB in the patron record. 2. Add a date, either manually or using the date picker. 3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 4. The date easily becomes malformed. 5. APPLY PATCHSET, maybe clear your browser cache too 6. Try directly inputing dates. I would suggest the following places: -Patron record DOB -Specify due date on circ/circulation.pl as this includes time -Add item screen, this is the dateaccessioned plugin -OPAC self reg/self modify Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lucas@bywatersolutions.com |kyle@bywatersolutions.com CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169135|0 |1 is obsolete| | Attachment #169136|0 |1 is obsolete| | Attachment #169137|0 |1 is obsolete| | Attachment #169138|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169151&action=edit Bug 37371: Move Maskito instantiation to onReady Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169152&action=edit Bug 37371: Set overwrite mode to replace In our case I think overwriteMode needs to be set to replace: https://maskito.dev/core-concepts/overwrite-mode Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169153&action=edit Bug 37371: Move Maskito init to onReady in dateaccessioned.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169154&action=edit Bug 37371: Move Maskito instantiation to onReady ( OPAC ) To test: 1. Find a any date picker in Koha, like DOB in the patron record. 2. Add a date, either manually or using the date picker. 3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 4. The date easily becomes malformed. 5. APPLY PATCHSET, maybe clear your browser cache too 6. Try directly inputing dates. I would suggest the following places: -Patron record DOB -Specify due date on circ/circulation.pl as this includes time -Add item screen, this is the dateaccessioned plugin -OPAC self reg/self modify Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.04 released in| | Status|Pushed to main |Pushed to stable --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33703 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #22 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This looks like a bug fix, nothing to change/edit in the manual. Please reopen with more details if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org