[Bug 5905] New: Biblibre, Partial fine payments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Bug #: 5905 Summary: Biblibre, Partial fine payments Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Blocks: 5575 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-20 22:26:17 UTC --- We appear to be missing the db changes to make these patches work .. Paul do you know where they are? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-20 22:26:50 UTC --- Created attachment 3369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3369 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-20 22:27:29 UTC --- Created attachment 3370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3370 Follow up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-03-23 01:57:13 UTC --- Created attachment 3409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3409 broken css The css for buttons doesn't work in FF4 on Mac OSX -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-03-23 01:57:54 UTC --- Created attachment 3410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3410 correct css The CSS works on other tabs in the fines area, but not that first one. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-03-23 01:58:40 UTC --- When I add a fine through a manual invoice I get the following: Software error: Can't use an undefined value as a HASH reference at /home/nengard/kohaclone/C4/Accounts.pm line 382. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-03-23 01:59:45 UTC --- Created attachment 3411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3411 n degree? What is this column for? n degree doesn't mean anything that I know of in the US. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |paul.poulain@biblibre.com --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-03-23 02:01:05 UTC --- All the above tests were before applying the follow up - after the follow up I get the following on the fines page: Software error: syntax error at /home/nengard/kohaclone/C4/Accounts.pm line 200, near ") # FIXME - The second argument to &UpdateStats is supposed to be the # branch code. # UpdateStats is now being passed $accountno too. MTJ UpdateStats" Compilation failed in require at /home/nengard/kohaclone/C4/Reserves.pm line 31. BEGIN failed--compilation aborted at /home/nengard/kohaclone/C4/Reserves.pm line 31. Compilation failed in require at /home/nengard/kohaclone/C4/Circulation.pm line 26. BEGIN failed--compilation aborted at /home/nengard/kohaclone/C4/Circulation.pm line 26. Compilation failed in require at /home/nengard/kohaclone/C4/Overdues.pm line 26. BEGIN failed--compilation aborted at /home/nengard/kohaclone/C4/Overdues.pm line 26. Compilation failed in require at /home/nengard/kohaclone/C4/Members.pm line 29. BEGIN failed--compilation aborted at /home/nengard/kohaclone/C4/Members.pm line 29. Compilation failed in require at /home/nengard/kohaclone/C4/Auth.pm line 30. BEGIN failed--compilation aborted at /home/nengard/kohaclone/C4/Auth.pm line 30. Compilation failed in require at /home/nengard/kohaclone/members/boraccount.pl line 26. BEGIN failed--compilation aborted at /home/nengard/kohaclone/members/boraccount.pl line 26. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3369|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-30 09:08:23 UTC --- Created attachment 3518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3518 Completed and rebased patch Initial patch was incomplete. This is the full patch from BibLibre, rebased on master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3370|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-30 09:11:12 UTC --- Created attachment 3519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3519 Follow up patch Follow up fixing sql to use placeholders. Adding a missing ';' from previous follow up patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-30 09:12:28 UTC --- Created attachment 3520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3520 Follow up patch Change 'n°' to 'no.' which is the correct abbreviation for number. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Depends on| |5728 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-30 09:15:13 UTC --- Depends on bug 5728 for `note` and `manager_id` fields in accountlines table. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3518|0 |1 is obsolete| | --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> 2011-04-07 09:01:21 UTC --- Created attachment 3773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3773 Rebased patch Previous rebased patch does not apply. Rebased again. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> 2011-05-02 13:56:34 UTC --- Patches must be applied in this order : attachment 3773 attachment 3519 attachment 3520 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #15 from Nicole C. Engard <nengard@gmail.com> 2011-05-13 19:47:24 UTC --- I tried to apply the first patch (in the order you listed) and got this: -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5905: lot of updates for borrower's fines fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 5905: lot of updates for borrower's fines When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ I obviously did not try the others after it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |stephane.delaune@biblibre.c | |om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|5728 |7671, 7672 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org