[Bug 21158] New: Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Bug ID: 21158 Summary: Add cronjob references to the system preference descriptions if a cronjob is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Add a reference in the system preference description saying this syspref requires a cronjob in order to work properly. Something like "Note: This system preference requires the misc/cronjobs/blah-blah.pl. Ask you system administrator to schedule it." The following system preferences require cronjobs. The starred sysprefs already have a reference to their cronjob, but it would be nice to standardize the message. - StaticHoldsQueueWeight: misc/cronjobs/holds/build_holds_queue.pl - ExpireReservesMaxPickUpDelay: misc/cronjobs/holds/cancel_expired_holds.pl - AutoResumeSuspendedHolds: misc/cronjobs/holds/auto_unsuspend_holds.pl - * finesMode: misc/cronjobs/fines.pl - DefaultLongOverdueLostValue: misc/cronjobs/longoverdue.pl - DefaultLongOverdueChargeValue: misc/cronjobs/longoverdue.pl - PatronSelfRegistrationExpireTemporaryAccountsDelay: misc/cronjobs/delete_expired_opac_registrations.pl - PatronSelfRegistrationVerifyByEmail: misc/cronjobs/delete_unverified_opac_registrations.pl - EnhancedMessagingPreferences: misc/cronjobs/process_message_queue.pl & misc/cronjobs/advance_notices.pl - NewItemsDefaultLocation: misc/cronjobs/cart_to_shelf.pl - InProcessingToShelvingCart: misc/cronjobs/cart_to_shelf.pl - ReturnToShelvingCart: misc/cronjobs/cart_to_shelf.pl - * AuthorityMergeLimit: misc/migration_tools/merge_authority.pl - * OpacBrowser: misc/cronjobs/build_browser_and_cloud.pl - * OpacCloud: misc/cronjobs/build_browser_and_cloud.pl - * UsageStats: share_usage_with_koha_community.pl - * PurgeSuggestionsOlderThan: misc/cronjobs/purge_suggestions.pl - MembershipExpiryDaysNotice: misc/cronjobs/membership_expiry.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 77484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77484&action=edit Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |dilan@calyx.net.au --- Comment #2 from Dilan Johnpullé <dilan@calyx.net.au> --- Ran into issue trying to apply: vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 21158 Bug 21158 - Add cronjob references to the system preference descriptions if a cronjob is required 77484 - Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required /home/vagrant/kohaclone/.git/rebase-apply/patch:184: trailing whitespace. - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/holds/build_holds_queue.pl</code> cronjob. Ask you system administrator to schedule it." warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref <stdin>:184: trailing whitespace. - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/holds/build_holds_queue.pl</code> cronjob. Ask you system administrator to schedule it." warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Failed to merge in the changes. Patch failed at 0001 Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21158-Add-cronjob-references-to-the-system-pre-0j9bCi.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77484|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 80953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80953&action=edit Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Attachment #80953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81608&action=edit Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. Followed test plan and patch is as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81608|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81795&action=edit Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. Followed test plan and patch is as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=12258 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81796&action=edit Bug 12258: (QA follow-up) Add some missing rrrrrrs Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06... It's never a bad thing to be a little bit clearer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not to push to 17.11.x to avoid translation work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #6)
Created attachment 81796 [details] [review] Bug 12258: (QA follow-up) Add some missing rrrrrrs
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Oups commit message is with wrong bug number 12258 instead of 21158. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why PatronSelfRegistrationVerifyByEmail? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28971 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Also, all these paths are wrong for every installation except a dev installation... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28979 [Bug 28979] Cronjob references in system preference descriptions don't make sense for most installations -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org