[Bug 8701] New: Help for OpacHiddenItems pref should not point to text in install directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Priority: P5 - low Change sponsored?: --- Bug ID: 8701 Assignee: nengard@gmail.com Summary: Help for OpacHiddenItems pref should not point to text in install directory Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: Documentation Product: Koha The description for the OpacHiddenItems preference says to refer to "docs/opac/OpacHiddenItems.txt." We have help files included with Koha and a manual online. We should point the user to one of those resources instead of one which isn't web-accessible and which isn't translated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Jane Sandberg <sandbergja@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |sandbergja@gmail.com Assignee|nengard@gmail.com |sandbergja@gmail.com --- Comment #1 from Jane Sandberg <sandbergja@gmail.com> --- Pull request on GitHub: https://github.com/Koha-Community/Koha/pull/1 Replaced all references to docs/opac/OpacHiddenItems.txt to refer to online documentation. In most cases, this was the English documentation (http://manual.koha-community.org/3.8/en/administration.html#OpacHiddenItems), but referred to French documentation (http://manual.koha-community.org/3.8/fr/opacprefs.html#OpacHiddenItems) in the fa-Arab, fr-FR, and sq-AL files. In addition to the ~60 .po files, there were three more files that I changed: *installer/data/mysql/updatedatabase.pl *installer/data/mysql/sysprefs.sql *koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref P.S. Sorry for taking your bug... :-( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Hi Jane Thanks heaps for your work, however, you shouldn't change the .po files, they are automatically generated, and then translated at http://translate.koha-community.org If you could rebase your commit, and remove the changes to the .po files (just the 3 other files are all that are needed to be changed). Then if you attach that here as a patch, it can go to needs signoff, and another developer can sign off on it. Thanks again Chris -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 --- Comment #3 from Jane Sandberg <sandbergja@gmail.com> --- Created attachment 12733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12733&action=edit Proposed patch for Bug 8701 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Jane Sandberg <sandbergja@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Jane Sandberg <sandbergja@gmail.com> --- Hi Chris Thanks for your guidance. Here is the bug fix without the .po files -- just the 3 files that needed to be changed. I've attached a patch; let me know if the patch is not as it should be. Sorry, I'm new to all of this -- thanks for your understanding. :-) -Jane (In reply to comment #2)
Hi Jane
Thanks heaps for your work, however, you shouldn't change the .po files, they are automatically generated, and then translated at http://translate.koha-community.org
If you could rebase your commit, and remove the changes to the .po files (just the 3 other files are all that are needed to be changed). Then if you attach that here as a patch, it can go to needs signoff, and another developer can sign off on it.
Thanks again
Chris
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Hi Jane You are doing great, just a few issues now, by changing the old updatedatabase.pl statement, this will mean this change will not be made to anyone upgrading from any version later than 3.4.0. So we might have to add another update stanza to change the value for those who have already updated? Also, while I would be willing to push this for 3.8.x (with the above change) for 3.10 it should probably point to the 3.10 .. manual .. and then for 3.12 etc. So this will need to be updated each feature release, I wonder if we can figure out a better way. But for 3.8.x im happy to push this (once it updates for upgrades also). Thanks so much for working on this, we really appreciate any time anyone can spend bug fixing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mirko@abunchofthings.net --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Hi Jane, thanks a lot for working on this. Changing the bug status to "in discussion" for now as it needs another database update as Chris explained. If you have any questions feel free to ask :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org