http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22094|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 22105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22105&action=edit [SIGNED-OFF] Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold There is a problem with how an active single language is styled, making the alignment look incorrect. This patch amends the markup and the CSS to make it look better. This patch does not address the position of the language menu. To test you must have at least one additional single translation installed. Apply the patch, refresh the page, and confirm that the display of the active language is improved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Improved view of current language. No koha-qa errors. 1) Downloaded a couple of xx-YY-bootstrap.po from http://translate.koha-community.org/projects/314 2) Installed sample languages 3) Enable them and opaclanguagesdisplay 4) Checked correct alignment of selected language -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Ed Veal <ed.veal@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22105|0 |1 is obsolete| | --- Comment #3 from Ed Veal <ed.veal@bywatersolutions.com> --- Created attachment 22108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22108&action=edit [SIGNED-OFF] Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold There is a problem with how an active single language is styled, making the alignment look incorrect. This patch amends the markup and the CSS to make it look better. This patch does not address the position of the language menu. To test you must have at least one additional single translation installed. Apply the patch, refresh the page, and confirm that the display of the active language is improved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Improved view of current language. No koha-qa errors. 1) Downloaded a couple of xx-YY-bootstrap.po from http://translate.koha-community.org/projects/314 2) Installed sample languages 3) Enable them and opaclanguagesdisplay 4) Checked correct alignment of selected language Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Ed Veal <ed.veal@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22108|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22325&action=edit Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold There is a problem with how an active single language is styled, making the alignment look incorrect. This patch amends the markup and the CSS to make it look better. This patch does not address the position of the language menu. To test you must have at least one additional single translation installed. Apply the patch, refresh the page, and confirm that the display of the active language is improved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Improved view of current language. No koha-qa errors. 1) Downloaded a couple of xx-YY-bootstrap.po from http://translate.koha-community.org/projects/314 2) Installed sample languages 3) Enable them and opaclanguagesdisplay 4) Checked correct alignment of selected language Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> The selected language has not a padding, contrary to others. Not perfect but it fixes the descripted behavior. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22325|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- I am setting this back to ASSIGNED, however -- the patch that was submitted addresses the side issue that Magnus identified, but does not address the main intent of the bug, which is making the language chooser visible without always requiring scrolling. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38870&action=edit Bug 11057: Bootstrap theme: Don't hide language chooser below the fold This patch removes one attribute from one class on opac.less Generated css files show language changer all the time To test: 1) Update and translate for a anguage of your choice 2) Enable lang on OPAC, also allow opaclanguagesdisplay 3) Go to OPAC, note language changer 'hidden', scroll to view 4) Apply the patch 5) Check you have node.js and lessc (nodejs and node-less packeages) 6) Compile and replace new opac.css lessc --compress koha-tmpl/opac-tmpl/bootstrap/less/opac.less > koha-tmpl/opac-tmpl/bootstrap/css/opac.css 7) Reload OPAC, check language changer is visible without scrolling. 8) Check Advanced search, Authority search, Tag cloud, Login page, etc Language changer must be visible without scroll I do not provide a new opac.css Hope Owen could take a look -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #9 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39289&action=edit "Powered by Koha" getting cut into Hi Bernardo, Ran the tests (both pre and post patching). The switcher panel *does* stay visible in place after patch. But I'm having the "Powered by Koha" cut away. 'opaccredits' is not impacted, -idg -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39290&action=edit Bug 11057: Follow-up - Bootstrap theme - recompiled css file -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Indranil Das Gupta from comment #9)

Created attachment 39289 [details] "Powered by Koha" getting cut into

Hi Bernardo,

Ran the tests (both pre and post patching). The switcher panel *does* stay visible in place after patch. But I'm having the "Powered by Koha" cut away. 'opaccredits' is not impacted,

-idg

I can reproduce, so it's not ready and needs more work. Thanks for testing :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #15 from Viktor Sarge <viktor.sarge@regionhalland.se> --- As a local fix I currently tried sticking this into OPACuserCSS: .navbar-fixed-bottom.navbar-static-bottom { margin-top: .5em; position: absolute; bottom: 0; left: 0; } Seems to work (and I guess it does the same thing more or less). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #17 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Agreed. Way to easy to reproduce that one :) -- You are receiving this mail because: You are watching all bug changes.