[Bug 27708] New: Cannot create EDI order if AcqCreateItem value is not "placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Bug ID: 27708 Summary: Cannot create EDI order if AcqCreateItem value is not "placing an order" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@helsinki.fi QA Contact: testopia@bugs.koha-community.org CC: nugged@gmail.com Depends on: 23926 There was a regression in bug 23926 which causes EDI orders to give internal server error if AcqCreateItem syspref is set to something other than "placing an order." The code from patch "Bug 23926: Limit GIR segment to 5 pieces of info" (f9efa7a9) assumes in the line
branchcode => $item->homebranch->branchcode,
that we have an Koha object but that is not true when AcqCreateItem is set to not create an item while placing the order. In that case we manually create hash representing item which has the key "branch" that contains the branchcode so the code "$item->homebranch->branchcode" doesn't work because it should be $item{branch}. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 [Bug 23926] In EDI Order limit GIR segment to five pieces of information -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 117453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117453&action=edit Bug 27708: unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object and then treated as one, but in the former item data was stored as hash keys in the same variable so later it was treated like an object, hence why it crashed. This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117453|0 |1 is obsolete| | --- Comment #2 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 117455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117455&action=edit Bug 27708: unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |stalkernoid@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Thanks for the patch! I think
$item_hash->{branch} = $branch;
Would need to be changed to
$item_hash->{branchcode} = $branch;
The delivery location info won't get transmitted otherwise. Can you please also add test for a) delivery place b) Some tests for when AcqCreateItem is different value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com, | |joonas.kylmala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117455|0 |1 is obsolete| | --- Comment #4 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 117568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117568&action=edit Bug 27708: unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117568|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 117665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117665&action=edit Bug 27708: unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Thanks for the nice test plan Peter! I've never dealt with EDI,so it was great to have a nice straight forward walk through. Testing notes: - Add an item to the basket in step 5 to generate the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #7 from David Nind <david@davidnind.com> --- Also, you may want to fix the Bug title to help it get through QA - after the Bug XXXX: it needs to start with a capital letter: Bug XXXX: Title of the bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- The tests are needed still for this to pass QA, so moving to FQA status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #9 from Peter Vashchuk <stalkernoid@gmail.com> --- (In reply to David Nind from comment #6)
Thanks for the nice test plan Peter!
I've never dealt with EDI,so it was great to have a nice straight forward walk through.
Hey, thanks for the sign-off!
Testing notes: - Add an item to the basket in step 5 to generate the error.
I didn't add anything about adding the item to the basket because you are able to sight the error even without adding anything to that basket, all you need to do is to press "Create EDIFACT order" which is available even if basket is empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #10 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 117722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117722&action=edit Bug 27708: Unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117665|0 |1 is obsolete| | Attachment #117722|0 |1 is obsolete| | --- Comment #11 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 117723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117723&action=edit Bug 27708: Unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #12 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127227&action=edit Bug 27708: (QA follow-up) Add a few tests for Koha::Edifact::Order 1. This adds a simple regression test to make sure order_line() method executes correctly with basket create_items set to "ordering" and "receiving". 2. A simple test for the filename method is added To test: 1) prove t/db_dependent/Koha/Edifact/Order.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117723|0 |1 is obsolete| | Attachment #127227|0 |1 is obsolete| | --- Comment #13 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127228&action=edit Bug 27708: Unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #14 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127229&action=edit Bug 27708: (QA follow-up) Add a few tests for Koha::Edifact::Order 1. This adds a simple regression test to make sure order_line() method executes correctly with basket create_items set to "ordering" and "receiving". 2. A simple test for the filename method is added To test: 1) prove t/db_dependent/Koha/Edifact/Order.t Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #15 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Added the missing unit test to make this pass QA, however the test is quite big so I would like to have separate sign-off and qa sign-off for the unit test patch. You can count my sign-off for the first patch as QA sign-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127228|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 127233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127233&action=edit Bug 27708: Unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127229|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 127234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127234&action=edit Bug 27708: (QA follow-up) Add a few tests for Koha::Edifact::Order 1. This adds a simple regression test to make sure order_line() method executes correctly with basket create_items set to "ordering" and "receiving". 2. A simple test for the filename method is added To test: 1) prove t/db_dependent/Koha/Edifact/Order.t Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127234|0 |1 is obsolete| | --- Comment #18 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 127264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127264&action=edit Bug 27708: (QA follow-up) Add a few tests for Koha::Edifact::Order 1. This adds a simple regression test to make sure order_line() method executes correctly with basket create_items set to "ordering" and "receiving". 2. A simple test for the filename method is added To test: 1) prove t/db_dependent/Koha/Edifact/Order.t Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Passing QA as all the patches have the required sign-offs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 127233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127233 Bug 27708: Unify two item object creation blocks to be stored as hash Review of attachment 127233: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27708&attachment=127233) ----------------------------------------------------------------- ::: Koha/Edifact/Order.pm @@ +392,5 @@
+ branchcode => $item->{branchcode}, + itype => $item->{itype}, + location => $item->{location}, + itemcallnumber => $item->{itemcallnumber}, + };
Pretty sure the above block causes breakage.. you are using `$item` as though it's a hash representation of an item row.. but it's not.. it's the hash of the AqOrdersItems link table.. so it doesn't contain branchcode, itype, location or itemcallnumber. It should be using the actual item row.. as before.. $i_obj This breaks our live systems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 127233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127233 Bug 27708: Unify two item object creation blocks to be stored as hash Review of attachment 127233: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27708&attachment=127233) ----------------------------------------------------------------- ::: Koha/Edifact/Order.pm @@ +392,5 @@
+ branchcode => $item->{branchcode}, + itype => $item->{itype}, + location => $item->{location}, + itemcallnumber => $item->{itemcallnumber}, + };
Pretty sure the above block causes breakage.. you are using `$item` as though it's a hash representation of an item row.. but it's not.. it's the hash of the AqOrdersItems link table.. so it doesn't contain branchcode, itype, location or itemcallnumber. It should be using the actual item row.. as before.. $i_obj This breaks our live systems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 [Bug 29670] Fix errors caused by bug 27708 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org