[Bug 20287] New: Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Bug ID: 20287 Summary: Move AddMember and ModMember to Koha::Patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Here is the whole stuff: https://gitlab.com/joubu/Koha/commits/bug_20287 I set the status Needs Signoff to ask for a code review. No test plan is provided here, you will have to read the code and find bugs or confirm everything sounds great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Hi Jonathan, I've read the code and added few comment to commits in gitlab, hope you've received a notice about that ;) Also, there are some issues reported by QA tools: FAIL C4/Members.pm FAIL pod *** ERROR: Spurious =cut command in file C4/Members.pm FAIL opac/opac-messaging.pl FAIL valid Global symbol "$borrower" requires explicit package name opac/opac-messaging.pl had compilation errors. FAIL opac/opac-registration-verify.pl FAIL valid "generate_password" is not exported by the Koha::AuthUtils module Can't continue after import errors FAIL tools/modborrowers.pl FAIL valid Global symbol "$success" requires explicit package name tools/modborrowers.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remove branch fixed and rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73436&action=edit Bug 20287: Fix tests expecting a warning The new Koha::Patron-based implementation encapsulates some error conditions that raised warnings and the tests expected that warning. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73436|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 73436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73436 Bug 20287: Fix tests expecting a warning Pushed to the remote branch, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tomas, could you sign-off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Signed of: https://gitlab.com/josef.moravec/Koha/tree/bug_20287 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- t/db_dependent/Koha/Object.t .. 3/11 DBD::mysql::st execute failed: Duplicate entry 'MB62Yq_MZzsGZK1vprKD' for key 'cardnumber' [for Statement "INSERT INTO `borrowers` ( `borrowernumber`, `branchcode`, `cardnumber`, `categorycode`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `guarantorid`, `password`, `privacy`, `privacy_guarantor_checkouts`, `sms_provider_id`, `userid`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=undef, 1='AofTnkLO7', 2='MB62Yq_MZzsGZK1vprKD', 3='WQQkZH3D', 4='2018-04-20T11:06:10', 5='4237-12-20T11:06:10', 6=undef, 7=undef, 8=undef, 9='!', 10=1, 11=0, 12=undef, 13='1'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # Failed test 'Exception is thrown correctly' # at t/db_dependent/Koha/Object.t line 292. # expecting: Koha::Exceptions::Object::DuplicateID # found: normal exit # Looks like you planned 10 tests but ran 7. # Looks like you failed 1 test of 7 run. # Failed test 'store() tests' # at t/db_dependent/Koha/Object.t line 315. Can't call method "message" without a package or object reference at t/db_dependent/Koha/Object.t line 295. # Looks like your test exited with 255 just after 10. t/db_dependent/Koha/Object.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/11 subtests Test Summary Report ------------------- t/db_dependent/Koha/Object.t (Wstat: 65280 Tests: 10 Failed: 1) Failed test: 10 Non-zero exit status: 255 Parse errors: Bad plan. You planned 11 tests but ran 10. Files=1, Tests=10, 3 wallclock secs ( 0.04 usr 0.00 sys + 2.48 cusr 0.25 csys = 2.77 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have no idea how to fix this failure correctly, it comes from bug 20590. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The problem with the tests is that we are using Koha::Patron to test Koha::Object. We should use a more simple object for that, Koha::Patron->store does a lot of things now and so the behaviours changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Jonathan Pattern ======= I'm not sure about the pattern you are using in ->store. Take a look here: http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Storage.pm#txn_do Basically, txn_do is encapsulating the exception you are raising, and so the behaviour is not the expected one. Failure in Object.t =================== Regarding the failure in Object.t, I agree we should pick a more simple object (I guess Koha::Patron was the first we introduced and was pretty simple until this patchset). Exceptions ========== On bug 20590 we introduced Koha::Exceptions::Exception->full_message (which should be moved into the implementing class (in the case you implemented, Koha::Exceptions::Object) but the way it is implemented works for the use case you wrote, but not for Koha::Object->store. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #11)
Jonathan
Pattern ======= I'm not sure about the pattern you are using in ->store. Take a look here:
http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Storage.pm#txn_do
Basically, txn_do is encapsulating the exception you are raising, and so the behaviour is not the expected one.
I am not sure to understand your point here, Koha::Exceptions::Object::FKConstraint is raised and correctly propagated.
Failure in Object.t =================== Regarding the failure in Object.t, I agree we should pick a more simple object (I guess Koha::Patron was the first we introduced and was pretty simple until this patchset).
I have added a new commit ("Use more simple object for Object.t")
Exceptions ========== On bug 20590 we introduced Koha::Exceptions::Exception->full_message (which should be moved into the implementing class (in the case you implemented, Koha::Exceptions::Object) but the way it is implemented works for the use case you wrote, but not for Koha::Object->store.
I think these patches highlight that the our exception system need to be reworked a bit and I think it's outside the scope of this bug. We should address it ASAP, once this pushed. See also new commit "Test exception DuplicateID for Koha::Patron->store" Remote branch has been rebased and the 2 commits added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21022 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 [Bug 21022] Exceptions should skip stringifying if message manually passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This has now had at least two QA runs (Tomas and Myself) and I believe all outstanding QA failing issues are resolved. I'm going to Pass QA and suggest we catch any fallout between now and release and even with all of our eyes on it there's bound to have been something creep through. Jonathan has done a great job, thankyou very much. As a side note.. after having discussed a few issues with him I have a few followup bugs to create that relate to this but should not hold up it's continuance. One being a case where none of us was entirely 100% sure about where a 'sync' key was passed into ModBiblio in the pate for the NL syncing code (which I was going to asign to Magnus) and a second where a few pre-existing race conditions are made much more obvious by this work. Passing QA :) Jonathan, can you add Signoff lines for Josef, Tomas and Me :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21069 [Bug 21069] Koha::Patron->generate_userid use encourages a race condition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76901&action=edit Bug 20287: Move fixup_cardnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76902&action=edit Bug 20287: Move trim values to a method Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76903&action=edit Bug 20287: Koha::Object->get_from_storage May be part of a separate bug report if needed TODO - add POD + tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76904&action=edit Bug 20287: Move AddMember to Koha::Patron->store Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76905&action=edit Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76906&action=edit Bug 20287: Fix export issues in tests t/db_dependent/Holds/RevertWaitingStatus.t .. Undefined subroutine &C4::Circulation::MoveReserve called at /home/vagrant/kohaclone/C4/Circulation.pm line 1316. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76907&action=edit Bug 20287: Remove warning If there are no patrons in DB: Use of uninitialized value in addition (+) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76908&action=edit Bug 20287: New warning in t/db_dependent/Koha/Object.t (?) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76909&action=edit Bug 20287: Use DBIC transaction instead of AutoCommit=0 Remove error "Already in a transaction" Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76910&action=edit Bug 20287: Remove AddMember_Auto I am not sure I understood the point of this subroutine. Did I miss something here? Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76911&action=edit Bug 20287: Add plain_text_password (& Remove AddMember_Opac) But actually we could remove it if it does not make sense for other use. Callers could deal with it since the password is not generated here Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76912&action=edit Bug 20287: Move ModMember to Koha::Patron Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76913&action=edit Bug 20287: ->store new deal with enrolment fee Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76914&action=edit Bug 20287: Fix test t/db_dependent/Members.t and prevent regressions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76915&action=edit Bug 20287: There is a warning, we just want to unset the value here Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76916&action=edit Bug 20287: Replace ModMember in patrons import Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76917&action=edit Bug 20287: Fix update of patrons, clean the data before ->store Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76918&action=edit Bug 20287: generate_userid now set the userid Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76919&action=edit Bug 20287: Replace occurrences of AddMember in REST API Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76920&action=edit Bug 20287: Replace occurrences of ModMember in REST API Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76921&action=edit Bug 20287: Fix tests expecting a warning The new Koha::Patron-based implementation encapsulates some error conditions that raised warnings and the tests expected that warning. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76922&action=edit Bug 20287: Use more simple object for Object.t We initially use Koha::Patron to test Object.t, but now it overwrites ->store and so it is better to use a more simple object. ApiKey has foreign keys and unique key. We lost one test: there is only one unique key whereas we had 2 on borrowers (I did not find a better option) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76923&action=edit Bug 20287: Test exception DuplicateID for Koha::Patron->store Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76924&action=edit Bug 20287: (QA follow-up) Fix warning on undefined Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76927&action=edit Bug 20287: (follow-up) Test exception DuplicateID for Koha::Patron->store -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226 [Bug 20226] Get rid of CATCODE_MULTI param decision in patron perl scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086 [Bug 21086] Wrong mock of DateTime->now in tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21085 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085 [Bug 21085] Can't edit patrons with housebound module active -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 [Bug 21087] Patron's password is hashed twice when the object is saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77221&action=edit Bug 20287: (RM follow-up) Restore use C4::Members -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Follow-up patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Bug 20287 depends on bug 21022, which changed state. Bug 21022 Summary: Exceptions should skip stringifying if message manually passed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136 [Bug 21136] Error "No property select_city for Koha::Patron" when saving patron record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21149 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21149 [Bug 21149] Administrator creation in onboarding always fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #43 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 21110 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374 [Bug 21374] Self registration e-mail verification does not work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Backported 'Bug 20287: Koha::Object->get_from_storage' patch only (as it's very helpful for bugfix's that create new tests relying upon it) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Only the release notes| |Koha::Object->get_from_stor | |age method has been | |backported for the 18.05.05 | |release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Only the |The release notes|Koha::Object->get_from_stor |Koha::Object->get_from_stor |age method has been |age method was backported |backported for the 18.05.05 |for the 18.05.05 release |release. |for use in tests required | |for other backports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596 [Bug 21596] Handle default values when storing Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The | release notes|Koha::Object->get_from_stor | |age method was backported | |for the 18.05.05 release | |for use in tests required | |for other backports. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 [Bug 22717] google oauth auto registration error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26940 [Bug 26940] debarred comment in borrowers table is lost on patron modifications in memberentry.pl page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26940 Depends on|26940 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26940 [Bug 26940] debarred comment in borrowers table is lost on patron modifications in memberentry.pl page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org