[Bug 16412] New: Cache undef in L1 only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 Bug ID: 16412 Summary: Cache undef in L1 only Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org No need to cache undef in L2. Prevent numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51086&action=edit Bug 16412: Cache undef in L1 only No need to cache undef in L2. Prevent numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 Test plan: Run t/Cache.t Run t/db_dependent/sysprefs.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51089&action=edit Bug 16412: Make sure Koha::Cache->set_in_cache will not warn anymore Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51086|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51090&action=edit Bug 16412: Cache undef in L1 only No need to cache undef in L2. Prevent numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 Test plan: Run t/Cache.t Run t/db_dependent/sysprefs.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: remove trailing space char and replace 'you' with 'we' to match existing wordings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks, Jonathan. Just to clarify for QA: If you use memcached, this patch will remove numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51089|0 |1 is obsolete| | Attachment #51090|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51310&action=edit [PASSED QA] Bug 16412: Make sure Koha::Cache->set_in_cache will not warn anymore Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51311&action=edit [PASSED QA] Bug 16412: Cache undef in L1 only No need to cache undef in L2. Prevent numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 Test plan: Run t/Cache.t Run t/db_dependent/sysprefs.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: remove trailing space char and replace 'you' with 'we' to match existing wordings. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jweaver@bywatersolutions.co | |m --- Comment #7 from Jesse Weaver <jweaver@bywatersolutions.com> --- Pushed for inclusion in 16.05, to be released in May 2015. Thanks for your work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 --- Comment #8 from Jesse Weaver <jweaver@bywatersolutions.com> --- May 2016, rather... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16044 Status|Pushed to Master |RESOLVED CC| |julian.maurice@biblibre.com Resolution|--- |FIXED --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 [Bug 16044] Define a L1 cache for all objects set in cache -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Julian Maurice from comment #9)
Not needed in stable versions, status changed to RESOLVED
Now needed because bug 16044 was pushed to 3.22.x Patches pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org