[Bug 41857] New: Suggestions table actions broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Bug ID: 41857 Summary: Suggestions table actions broken Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com, | |jonathan.druart@gmail.com, | |martin.renvoize@openfifth.c | |o.uk, | |matt.blenkinsop@openfifth.c | |o.uk, | |pedro.amorim@openfifth.co.u | |k See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38192 Depends on| |39721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 [Bug 39721] Remove GetSuggestion from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193184&action=edit Bug 41857: Remove suggestion I don't understand why we need this here, but it seems to be picking up a leftover suggestion from a previous loop. This code itself is not within a loop, so it doesnt have the hashref containing suggestiontype from suggestion.pl. It's trying to access suggestiontype from Koha::Suggestion which causes an explosion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193185&action=edit Bug 41857: Use suggesteddate_from and suggesteddate_to
From URL params. I believe this was an overupdate from bug 39721.
Test plan: 1) Create a new suggestion: http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?op=add_form&branchcode= 2) Add a title and submit. 3) From the table, select the suggesiton (check the box). 4) Click the 'submit' under 'Update manager' or 'Delete selected'. 5) Error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Stumbled upon this while rebasing bug 40504 on top of 39721. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- update manager with more than one (or none) and you get a 500 DBIx::Class::ResultSet::find(): find() expects either a column/value hashref, or a list of values corresponding to the columns of the specified unique constraint 'primary' at /kohadevbox/koha/Koha/Objects.pm line 95 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 DBIx::Class::Exception::throw('DBIx::Class::Exception', 'find() expects either a column/value hashref, or a list of values corresponding to the columns of the specified unique constraint \'primary\'', 0) c alled at /usr/share/perl5/DBIx/Class/Schema.pm line 1118 DBIx::Class::Schema::throw_exception('Koha::Schema=HASH(0x63f676efab10)', 'find() expects either a column/value hashref, or a list of values corresponding to the columns of the specified unique constraint \'primary\'') called at /usr/share/perl5/DBIx/Class/ResultSource.pm line 2379 DBIx::Class::ResultSource::throw_exception('DBIx::Class::ResultSource::Table=HASH(0x63f6773b6850)', 'find() expects either a column/value hashref, or a list of values corresponding to the columns of the sp ecified unique constraint \'primary\'') called at /usr/share/perl5/DBIx/Class/ResultSet.pm line 4011 DBIx::Class::ResultSet::throw_exception('DBIx::Class::ResultSet=HASH(0x63f6794baee0)', 'find() expects either a column/value hashref, or a list of values corresponding to the columns of the specified uniqu e constraint \'primary\'') called at /usr/share/perl5/DBIx/Class/ResultSet.pm line 809 DBIx::Class::ResultSet::find('DBIx::Class::ResultSet=HASH(0x63f6794baee0)', 1, 2) called at /kohadevbox/koha/Koha/Objects.pm line 95 Koha::Objects::find('Koha::Suggestions', 1, 2) called at /kohadevbox/koha/suggestion/suggestion.pl line 105 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Yes, caused by: $stored_suggestion = Koha::Suggestions->find(1 $input->param('suggestionid') ) if $input->param('suggestionid'); Also added in bug 39721. suggestionid may be multiple. Looking. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193256&action=edit Bug 41857: Only find singly suggestion by id if 'edit_form' All ops that iterate on editsuggestions can potentially have multiple suggestionid and don't need stored_suggestion cud-update_status cud-delete cud-archive cud-unarchive cud-update_itemtype cud-update_manager I'm unsure if op = 'else' should also be included with edit_form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193184|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193185|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 193268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193268&action=edit Bug 41857: Remove suggestion I don't understand why we need this here, but it seems to be picking up a leftover suggestion from a previous loop. This code itself is not within a loop, so it doesnt have the hashref containing suggestiontype from suggestion.pl. It's trying to access suggestiontype from Koha::Suggestion which causes an explosion Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 193269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193269&action=edit Bug 41857: Use suggesteddate_from and suggesteddate_to
From URL params. I believe this was an overupdate from bug 39721.
Test plan: 1) Create a new suggestion: http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?op=add_form&branchcode= 2) Add a title and submit. 3) From the table, select the suggesiton (check the box). 4) Click the 'submit' under 'Update manager' or 'Delete selected'. 5) Error Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 193270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193270&action=edit Bug 41857: Only find singly suggestion by id if 'edit_form' All ops that iterate on editsuggestions can potentially have multiple suggestionid and don't need stored_suggestion cud-update_status cud-delete cud-archive cud-unarchive cud-update_itemtype cud-update_manager I'm unsure if op = 'else' should also be included with edit_form Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Signed Off Text to go in the| |This fixes errors that are release notes| |generated when selecting a | |suggestion in the staff | |interface and: | |- Updating the manager for | |the suggestion (Update | |manager > [select manager] | |> Submit) | |- Deleting the suggestion | |(Delete selected > Submit) | | | |(Related to changes made by | |Bug 39721 - Remove | |GetSuggestion from | |C4/Suggestions.pm, added in | |Koha 26.05.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suggestions table actions |Suggestions table actions |broken |broken Update manager and | |Delete selected actions) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k --- Comment #10 from David Nind <david@davidnind.com> --- Updated the assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193269|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 193313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193313&action=edit Bug 41857: Remove suggestion I don't understand why we need this here, but it seems to be picking up a leftover suggestion from a previous loop. This code itself is not within a loop, so it doesnt have the hashref containing suggestiontype from suggestion.pl. It's trying to access suggestiontype from Koha::Suggestion which causes an explosion Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 193314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193314&action=edit Bug 41857: Use suggesteddate_from and suggesteddate_to
From URL params. I believe this was an overupdate from bug 39721.
Test plan: 1) Create a new suggestion: http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?op=add_form&branchcode= 2) Add a title and submit. 3) From the table, select the suggesiton (check the box). 4) Click the 'submit' under 'Update manager' or 'Delete selected'. 5) Error Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 193315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193315&action=edit Bug 41857: Only find singly suggestion by id if 'edit_form' All ops that iterate on editsuggestions can potentially have multiple suggestionid and don't need stored_suggestion cud-update_status cud-delete cud-archive cud-unarchive cud-update_itemtype cud-update_manager I'm unsure if op = 'else' should also be included with edit_form Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42071 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42071 [Bug 42071] Suggestion does not load when viewing the suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suggestions table actions |Suggestions table actions |broken Update manager and |broken (Update manager and |Delete selected actions) |Delete selected) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 --- Comment #15 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to stable |Needs documenting --- Comment #16 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x, as Bug 41857 depends on Bug 39721, which has not been backported to this branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #17 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41857 Bug 41857 depends on bug 39721, which changed state. Bug 39721 Summary: Remove GetSuggestion from C4/Suggestions.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org