[Bug 9506] New: Values are false in the generated pdf for basketgroups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Bug ID: 9506 Summary: Values are false in the generated pdf for basketgroups Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com Due to the multi VAT development (Bug 5335), values are not well calculated in the pdf generated by the basketgroup print action. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14944&action=edit Bug 9506: FIX GST values for the basketgroup print action Due to the multi VAT development (Bug 5335), values are not well calculated in the pdf generated by the basketgroup print action. Test plan: - Add one or more basket to a basketgroup. - Close and print this basketgroup - Check that different values correspond to values in the basket detail page. Don't forget to test with different parameters (multiple vat, vendor include/don't include tax). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5335 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Good work Jonathan ;-) I sign off. I like the replacement of the array by a hash too. It will be easier to edit basketgroup pdf templates! Maybe "Discount amount" would be better than "Discount price"? But I am not fluent in english... and it could be fixed latter. Details of my tests ; BEFORE applying the patch : I create a bookseller NOYES with : - List item price includes tax: No - Invoice item price includes tax: Yes - tax rate : 5.5 - discount : 9% I create a basket with : - a book costing 100 euros (vendor price) - a book costing 50 euros (vendor price), in 2 items I check basket.pl : all is correct : for the book costing 100 euros : - RP tax exc. : 100 - ecost tax exc : 91 - RP tax inc : 105.5 - ecost tax incl : 96 and half these values for the book costing 50 euros total correct (on discounted prices) - Total tax exc. (EUR) 182.00 - Total tax inc. (EUR) 192.00 - GST (EUR) 10.00 I close the basket, create a basketgroup, and print the basketgroup with layout3pages => WRONG prices 1st page : RRT GST Inc. : 200 Discount Price : 182 Total GST exc : 172,51 GST : 9,49 Total GST Inc. : 182 2d page, for the book costing 100 euros : RRT GST Inc : 100 Discount price GST Exc. : 86,26 Total GST Inc. : 91 AFTER applying the patch : I print again the same basketgroup with layout3pages => RIGHT prices 1st page : Total RRP tax exc : 200 Total RRP tax incl: 211 GST : 10 Total discount : 18 Total Tax exc : 182 Total Tax incl : 192 2d page, for the book costing 100 euros tax exc : RRP tax exc : 100 RRP tax inc : 105.5 Discount price : 9 Total tax exc. : 91 Total tax incl : 96 For the 2 items of the book costing 50 euros, everything is correct too. (Total tax exc. : 91 ; Total tax incl : 96) Same test with a 2d bookseller YESYES with : - List item price includes tax: Yes - Invoice item price includes tax: Yes => everything is OK after patch is applied : 2 items of a book with vendor price = 105,50 EUR tax inc : I print the basketgroup with layout3pages 1st page : Total RRP tax exc : 200 Total RRP tax incl: 211 GST : 10 Total discount : 18 Total Tax exc : 182 Total Tax incl : 192 2d page, for the book costing 105,5 euros tax inc : Qty : 2 RRP tax exc : 100 RRP tax inc : 105.5 Discount price : 9 Total tax exc. : 182 Total tax incl : 192 M. Saby Rennes 2 university -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14944|0 |1 is obsolete| | --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 15041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15041&action=edit [SIGNED OFF] Bug 9506: FIX GST values for the basketgroup print action Due to the multi VAT development (Bug 5335), values are not well calculated in the pdf generated by the basketgroup print action. Test plan: - Add one or more basket to a basketgroup. - Close and print this basketgroup - Check that different values correspond to values in the basket detail page. Don't forget to test with different parameters (multiple vat, vendor include/don't include tax). Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16586&action=edit screenshot The calculation looks alright to me, but there is a little problem when using pdfformat::layout3pages as PDF layout. On the second page that shows the baskets in the basket group there is a column "gst rate". It currently always shows a list with the gst rate for every order line of the first basket (see screenshot). 2 Problems here: - First baskets gst rates are shown for all baskets - The list of gst rates is not deduplicated - it's one entry for each order line. Maybe we should just say "Multiple" or something if there is more than one? Or maybe remove the columns altogether and just keep the sum in the next column? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16620&action=edit Bug 9506: FIX gst list values for each basket -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #4)
2 Problems here: - First baskets gst rates are shown for all baskets Fixed, bad placed variable.
- The list of gst rates is not deduplicated - it's one entry for each order line. Maybe we should just say "Multiple" or something if there is more than one? Or maybe remove the columns altogether and just keep the sum in the next column? Really strange behavior, appears just for 0 value. Now it is fixed.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15041|0 |1 is obsolete| | Attachment #16620|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16705&action=edit [PASSED QA] Bug 9506: FIX GST values for the basketgroup print action Due to the multi VAT development (Bug 5335), values are not well calculated in the pdf generated by the basketgroup print action. Test plan: - Add one or more basket to a basketgroup. - Close and print this basketgroup - Check that different values correspond to values in the basket detail page. Don't forget to test with different parameters (multiple vat, vendor include/don't include tax). Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16706&action=edit [PASSED QA] Bug 9506: FIX gst list values for each basket Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Problems raised by QA for the basket list page in the 3 pages layout (pdfformat::layout3pages) fixed. GST column on the summary page now gives a list of all used GST rates for each individual basket. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org