[Bug 16240] New: Regression: Bug 16082 causes message to be displayed even when no borrowernumber is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Bug ID: 16240 Summary: Regression: Bug 16082 causes message to be displayed even when no borrowernumber is passed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: brendan@bywatersolutions.com, gmcharlt@gmail.com, jonathan.druart@bugs.koha-community.org, julian.maurice@biblibre.com, kyle.m.hall@gmail.com, testopia@bugs.koha-community.org, veron@veron.ch Blocks: 16082 Bug 16082 made this change: "On circulation.pl, an empty patron detail page is displayed if the patron does not exist. A friendly message should be displayed instead." However, now if you navigate directly to /cgi-bin/koha/circ/circulation.pl you will see a message, "This patron does not exist." The message should only be displayed if a borrowernumber or card number was passed and not found. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 [Bug 16082] Empty patron detail page is displayed if the patron does not exist - circulation.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50141&action=edit Bug 16240: (follow-up for 16082) Do not display message if no borrowernumber passed "This patron does not exist" message should not be displayed on the "Checkouts home page". The message should only be displayed if the borrowernumber parameter is passed. Test plan: Go on circ/circulation.pl => No message Go on circ/circulation.pl?borrowernumber=424242 => You should see the message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50141|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 50149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50149&action=edit Bug 16240: (follow-up for 16082) Do not display message if no borrowernumber passed "This patron does not exist" message should not be displayed on the "Checkouts home page". The message should only be displayed if the borrowernumber parameter is passed. Test plan: Go on circ/circulation.pl => No message Go on circ/circulation.pl?borrowernumber=424242 => You should see the message Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50149|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50217&action=edit [PASSED QA] Bug 16240: (follow-up for 16082) Do not display message if no borrowernumber passed "This patron does not exist" message should not be displayed on the "Checkouts home page". The message should only be displayed if the borrowernumber parameter is passed. Test plan: Go on circ/circulation.pl => No message Go on circ/circulation.pl?borrowernumber=424242 => You should see the message Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org