[Bug 22206] New: Add route to handle holds suspensions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug ID: 22206 Summary: Add route to handle holds suspensions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com Target Milestone: --- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Holds_suspension_ | |endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 [Bug 20006] Adapt /v1/holds to new naming guidelines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 [Bug 21478] Koha::Hold->suspend_hold allows suspending in transit holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |22132, 19816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 [Bug 19816] output_pref must implement 'dateonly' for dateformat => rfc3339 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 [Bug 22132] Add Basic authentication to the REST API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84473&action=edit Bug 22206: OpenAPI spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84474&action=edit Bug 22206: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84475&action=edit Bug 22206: Add routes to suspend/resume holds This patch introduces: - POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" } - DELETE /holds/{hold_id}/suspension to suspend a hold or resume a suspended hold, respectively. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84473|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85056&action=edit Bug 22206: OpenAPI spec Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84474|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85057&action=edit Bug 22206: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84475|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85058&action=edit Bug 22206: Add routes to suspend/resume holds This patch introduces: - POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" } - DELETE /holds/{hold_id}/suspension to suspend a hold or resume a suspended hold, respectively. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Seems solid work to me.. tested and working, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug 22206 depends on bug 22132, which changed state. Bug 22132 Summary: Add Basic authentication to the REST API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug 22206 depends on bug 19816, which changed state. Bug 19816 Summary: output_pref must implement 'dateonly' for dateformat => rfc3339 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85056|0 |1 is obsolete| | Attachment #85057|0 |1 is obsolete| | Attachment #85058|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85468&action=edit Bug 22206: OpenAPI spec Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85469&action=edit Bug 22206: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85470&action=edit Bug 22206: Add routes to suspend/resume holds This patch introduces: - POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" } - DELETE /holds/{hold_id}/suspension to suspend a hold or resume a suspended hold, respectively. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85471&action=edit Bug 22206: (QA follow-up) Fix tests for hold suspension api Test plan: prove t/db_dependent/api/v1/holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec@gmail.com Status|Passed QA |BLOCKED --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Looks good, I think it is ready, but we should wait for voting on development meeting. So setting BLOCKED (was Passed QA) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug 22206 depends on bug 21478, which changed state. Bug 21478 Summary: Koha::Hold->suspend_hold allows suspending in transit holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85862&action=edit Bug 22206: (follow-up) Voted RFC changes This patch changes expiration_date for end_date as voted when the RFC was approved. It also adds a test for the Location header being added correctly when suspending a hold (SWAGGER3.4.1) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85468|0 |1 is obsolete| | --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85864&action=edit Bug 22206: OpenAPI spec Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85469|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85865&action=edit Bug 22206: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85470|0 |1 is obsolete| | --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85866&action=edit Bug 22206: Add routes to suspend/resume holds This patch introduces: - POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" } - DELETE /holds/{hold_id}/suspension to suspend a hold or resume a suspended hold, respectively. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85471|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85867&action=edit Bug 22206: (QA follow-up) Fix tests for hold suspension api Test plan: prove t/db_dependent/api/v1/holds.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85862|0 |1 is obsolete| | --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85868&action=edit Bug 22206: (follow-up) Voted RFC changes This patch changes expiration_date for end_date as voted when the RFC was approved. It also adds a test for the Location header being added correctly when suspending a hold (SWAGGER3.4.1) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- More testing is always fine, and I even forget to add my sign-off line last time, fixed now ;) Thanks for quick follow-up Tomas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug 22206 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug 22206 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As per my policy of backporting new API routes, Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- *** Bug 19072 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug 22206 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add route to handle holds |Add routes to enable |suspensions |suspension or resumption of | |holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This new feature adds a release notes| |REST API that allows | |suspending a hold and | |resuming a suspended hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 [Bug 24813] api/v1/holds.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28377 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 [Bug 28377] Use the API to suspend/resume holds -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org