[Bug 16372] New: Replace the use of "onclick" for deletion confirmation in some templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Bug ID: 16372 Summary: Replace the use of "onclick" for deletion confirmation in some templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Several templates include the use of an "onclick" attribute to handle deletion confirmations: intranet-main.tt patron_lists/lists.tt patroncards/image-manage.tt tools/koha-news.tt These should be modified so that events are handled in JavaScript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50832&action=edit Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates This patch removes the use of event attributes from several templates where the attributes were used to handle deletion operations. I've grouped these changes in one patch because each template had only small changes to be made. Unrelated change: Reformatted the "no news items" message which is displayed if there are no news items. To test, apply the patch and test deletion operations on the following pages. Clicking "delete" should prompty you to confirm. Test both the confirm and cancel actions. - On the staff client home page, test deletion of a news item. - On the patron lists page, test deletion of a patron list. - In the patron card creator, choose Manage -> Images. Test the "Delete" button for a single image. - On the news page, test deletion of a single news item. - On the news page, test deletion of multiple items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Arslan Farooq <arslanone@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50832|0 |1 is obsolete| | Assignee|oleonard@myacpl.org |arslanone@gmail.com Status|Needs Signoff |Signed Off CC| |arslanone@gmail.com --- Comment #2 from Arslan Farooq <arslanone@gmail.com> --- Created attachment 50871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50871&action=edit Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates This patch removes the use of event attributes from several templates where the attributes were used to handle deletion operations. I've grouped these changes in one patch because each template had only small changes to be made. Unrelated change: Reformatted the "no news items" message which is displayed if there are no news items. To test, apply the patch and test deletion operations on the following pages. Clicking "delete" should prompty you to confirm. Test both the confirm and cancel actions. - On the staff client home page, test deletion of a news item. - On the patron lists page, test deletion of a patron list. - In the patron card creator, choose Manage -> Images. Test the "Delete" button for a single image. - On the news page, test deletion of a single news item. - On the news page, test deletion of multiple items. ----------------------------------------------------- All things were tested and everything worked OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 --- Comment #3 from Arslan Farooq <arslanone@gmail.com> --- Did QA tools as well, and it passed. However, there was that Plugins.pm message again "Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206." ----------------------------------------------------- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt OK forbidden patterns SKIP spelling OK tt_valid FAIL valid_template Attempt to reload Koha/Template/Plugin/Koha.pm aborted. Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206. OK koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template ----------------------------------------------------- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50871|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50887&action=edit [PASSED QA] Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates This patch removes the use of event attributes from several templates where the attributes were used to handle deletion operations. I've grouped these changes in one patch because each template had only small changes to be made. Unrelated change: Reformatted the "no news items" message which is displayed if there are no news items. To test, apply the patch and test deletion operations on the following pages. Clicking "delete" should prompty you to confirm. Test both the confirm and cancel actions. - On the staff client home page, test deletion of a news item. - On the patron lists page, test deletion of a patron list. - In the patron card creator, choose Manage -> Images. Test the "Delete" button for a single image. - On the news page, test deletion of a single news item. - On the news page, test deletion of multiple items. Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16386 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 [Bug 16386] Replace the use of "onclick" from patron card creator templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16058 CC| |julian.maurice@biblibre.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058 [Bug 16058] Add a button to delete an individual news item -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org