[Bug 40664] New: Serial subscription input missing "Required" labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Bug ID: 40664 Summary: Serial subscription input missing "Required" labels Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org On the second page of the 'Add a new [serial] subscription' form, there are fields that are mandatory (in red), but it doesn't say 'Required' next to them. To recreate: 1. Go to Serials 2. Click 'New subscription' 3. Enter a biblionumber in the 'Record' field (e.g. 230) 4. Click 'Next' 5. (Click 'OK' to confirm that you are not adding a vendor) --> On the page 'Add a new subscription (2/2)' the fields 'Frequency' and 'Subscription start date' are red to indicate that they are mandatory, but there is no 'Required' note next to them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 185514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185514&action=edit Bug 40664: Serial subscription input missing "Required" labels This patch adds missing "Required" labels next to two mandatory fields in the second page of the new serial subscription form. To test: 1. Go to Serials 2. Click 'New subscription' 3. Enter a biblionumber in the 'Record' field (e.g. 230) 4. Click 'Next' 5. (Click 'OK' to confirm that you are not adding a vendor) --> On the page 'Add a new subscription (2/2)' the fields 'Frequency' and 'Subscription start date' are red to indicate that they are mandatory, but there is no 'Required' note next to them. 6. Apply patch and refresh the page --> It should say 'Required' next to all the mandatory fields (in red) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Correction based on bug 40413 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185514|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 189485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189485&action=edit Bug 40664: Serial subscription input missing "Required" labels This patch adds missing "Required" labels next to two mandatory fields in the second page of the new serial subscription form. To test: 1. Go to Serials 2. Click 'New subscription' 3. Enter a biblionumber in the 'Record' field (e.g. 230) 4. Click 'Next' 5. (Click 'OK' to confirm that you are not adding a vendor) --> On the page 'Add a new subscription (2/2)' the fields 'Frequency' and 'Subscription start date' are red to indicate that they are mandatory, but there is no 'Required' note next to them. 6. Apply patch and refresh the page --> It should say 'Required' next to all the mandatory fields (in red) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the second page release notes| |of the new serial | |subscription form - it adds | |missing "Required" labels | |next to two mandatory | |fields | |('Frequency' and | |'Subscription start date'). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189485|0 |1 is obsolete| | --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189676&action=edit Bug 40664: Serial subscription input missing "Required" labels This patch adds missing "Required" labels next to two mandatory fields in the second page of the new serial subscription form. To test: 1. Go to Serials 2. Click 'New subscription' 3. Enter a biblionumber in the 'Record' field (e.g. 230) 4. Click 'Next' 5. (Click 'OK' to confirm that you are not adding a vendor) --> On the page 'Add a new subscription (2/2)' the fields 'Frequency' and 'Subscription start date' are red to indicate that they are mandatory, but there is no 'Required' note next to them. 6. Apply patch and refresh the page --> It should say 'Required' next to all the mandatory fields (in red) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40664 --- Comment #9 from David Nind <david@davidnind.com> --- Note for documentation update: - Screenshot updates required for 'addsub2' (page 2 of the subscription add form, has two additional fields for serials): . Administration (administration.rst) x2 . Serials (serials.rst) x1 - The screenshot includes two additional fields for serials - The automated screenshot needs work and is not yet validated: . It is a two part form with the same URL . The two additional fields need to be set up beforehand -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org