http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #1 from Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> --- Created attachment 41801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41801&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summery" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Make sure the branch has an email address specified 4) Check out an item to a patron 5) Log in with the patron you checked out the item for 6) In "your summery", write a message in the new "Note" field for the item checked out. Hit ENTER to save/send. 7) Success message should be seen and an email sent to the email address specified for the branch which the item was checked out from. 8) Log in with staff account and check in the item 9) The note should be shown The note can be changed by the patron at any time while the item is checked out. Each change will send a new email to the branch. Only the latest note version will be shown on check in. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in opac/opac-user.pl CONFLICT (content): Merge conflict in C4/Circulation.pm Tests are missing for the new subroutine. GetIssues which takes issue_id is more a GetIssue subroutine, don't you think? Why are you doing an ajax request? It won't work if the user does not have javascript enabled. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Stenberg from comment #4)

Hi Jonathan,

Do you think it's worth adding a new subroutine GetIssue for this special case of GetIssues? GetIssues will still return an arrayref when called with issue_id, so the return type matches the plural "s" at least.

GetIssue would not return an array, but the matching issue.

I'm doing an ajax request to minimize overhead when sending the request (i.e. no need to send note data for all issues when only one has been changed) and when recieving (i.e. no need to render a new template and send a whole document when only an "ok" or "nok" is needed). And as a bonus it allows the user to write a second note while the first one is beeing sent/processed to the server.

To be honest I thought javascript was concidered a requirment for Koha. I'm using NoScript myself, and am always positivly surprised when a page works without having to enable javascript.

How about keeping the ajax-version and adding a fallback for browsers without javascript?

You can add 2 forms in the page, the one needing JS can be hidden with a css rule. When the page is loading, a JS code could hide one and display the other one. I suppose it's the way to go. -- You are receiving this mail because: You are watching all bug changes.