[Bug 7049] New: Item form on order receive has lots of blank space
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 Bug #: 7049 Summary: Item form on order receive has lots of blank space Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/acqui/orderreceive.pl?ordernumber=65&inv oice=something&gst=0&supplierid=11 OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Created attachment 5942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5942 screenshot The item form on the order receive page (AcqCreateItem = on receive) contains a lot of blank space which makes it hard to read and fill out. I think Owen(?) fixed this for creating orders (AcqCreateItem = on order), but can't find the bug right now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 19:58:23 UTC --- Corresponding change to the item form for AcqCreateItem = on order was: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=9a2fd1bb7ed9e4a9... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 20:08:35 UTC --- Created attachment 5943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5943 Bug 7049: Item form on order receive has lots of blank space The item form on the order receive page (AcqCreateItem = on receive) contains a lot of blank space which makes it hard to read and fill out. To test: - set AcqCreateItem = on receive - create basket, order something, receive shipment - check item form is nicely formatted and doesn't include lots of blank space Note: It will be easier to test if you have an ACQ framework created to hide some unnecessary subfields, because the hidden fields create the blank space. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5943|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@enger.priv.no> 2011-10-19 13:00:04 UTC --- Created attachment 5976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5976 Bug 7049: [SIGNED-OFF] Item form on order receive has lots of blank space The item form on the order receive page (AcqCreateItem = on receive) contains a lot of blank space which makes it hard to read and fill out. To test: - set AcqCreateItem = on receive - create basket, order something, receive shipment - check item form is nicely formatted and doesn't include lots of blank space Note: It will be easier to test if you have an ACQ framework created to hide some unnecessary subfields, because the hidden fields create the blank space. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Created an ACQ framework and hid some of the fields (hidden = 5). Before the patch there were gaps between the fields as shown in the screenshot from Katrin. After the patch fields line up nicely, with no extra space between them. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-19 18:43:54 UTC --- Just moves hidden styling out of div an into <li> that wraps it, thereby removing extra spacing. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-19 22:58:10 UTC --- Template only change, not introducing any new strings pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7049 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org