[Bug 33580] New: Bring back ability to mark item as seen via SIP2 item information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Bug ID: 33580 Summary: Bring back ability to mark item as seen via SIP2 item information request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Prior to Koha 22.05, the SIP2 item information message had a side affect of updating the datelastseen field for items. This bug has been fixed, but was being utilized by inventory tools that used SIP2. We should bring back this affect and formalize it as an optional SIP2 config account setting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150032&action=edit Bug 33580 - Bring back ability to mark item as seen via SIP2 item information request Prior to Koha 22.05, the SIP2 item information message had a side affect of updating the datelastseen field for items. This bug has been fixed, but was being utilized by inventory tools that used SIP2. We should bring back this affect and formalize it as an optional SIP2 config account setting. Test Plan: 1) Apply this patch set 2) prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150032|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 150113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150113&action=edit Bug 33580 - Bring back ability to mark item as seen via SIP2 item information request Prior to Koha 22.05, the SIP2 item information message had a side affect of updating the datelastseen field for items. This bug has been fixed, but was being utilized by inventory tools that used SIP2. We should bring back this affect and formalize it as an optional SIP2 config account setting. Test Plan: 1) Apply this patch set 2) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - b097a2bf40 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- No blocker, but it is a bit obscure how the values of this option work. The documentation is quite poor.. The name could be improved too? + my $seen = $account->{seen_on_item_information}; + ModDateLastSeen( $item->itemnumber, $seen eq 'keep_lost' ) if $seen; + seen_on_item_information="mark_found"> <!-- could be "keep_lost", empty to disable --> Nevertheless passing QA to fix a regression. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150113|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151123&action=edit Bug 33580 - Bring back ability to mark item as seen via SIP2 item information request Prior to Koha 22.05, the SIP2 item information message had a side affect of updating the datelastseen field for items. This bug has been fixed, but was being utilized by inventory tools that used SIP2. We should bring back this affect and formalize it as an optional SIP2 config account setting. Test Plan: 1) Apply this patch set 2) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 151123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151123 Bug 33580 - Bring back ability to mark item as seen via SIP2 item information request Review of attachment 151123: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33580&attachment=151123) ----------------------------------------------------------------- ::: t/db_dependent/SIP/Message.t @@ +457,5 @@
+ $item_object->update({ itemlost => 1, datelastseen => '1900-01-01' }); + $server->{account}->{seen_on_item_information} = 'keep_lost'; + $msg->handle_item_information( $server ); + $item_object = Koha::Items->find( $item_object->id ); + isnt( $item_object->datelastseen, "1900-01-01", "datelastseen updated" );
The tests are failing due to date vs datetime format mismatch. However.. I think I'd also like ot have seen a different date used to prove the change.. at first glance this looks like it's checking the field that's already set.? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Doh.. I missed that it's an `isnt`! So, the test checks out.. but the format is still a problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151188&action=edit Bug 33580: fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks like some of you forgot that there is a --run-tests flag that you can pass to the qa script... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #9)
Created attachment 151188 [details] [review] Bug 33580: fix tests
My try at fixing the tests, no idea if it's correct but it seems to be what it should have been. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks like someone changed datelastseen :) commit f729d46478fbfbb258262888941a6aa42da04d70 Author: Lucas Gass <lucas@bywatersolutions.com> Date: Tue Feb 7 23:14:43 2023 +0000 Bug 31212: Change datelastseen from date to datetime field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Ho right, datelastseen has been changed to datetime on 31212, pushed at the same time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org