[Bug 22634] New: Standardize table creation for stockrotation* tables in kohacstructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Bug ID: 22634 Summary: Standardize table creation for stockrotation* tables in kohacstructure.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 11897 Target Milestone: --- (In reply to Jonathan Druart from comment #373)
CREATE TABLE statements do not follow the usual pattern:
CREATE TABLE IF NOT EXISTS stockrotationitems vs DROP TABLE IF EXISTS `circulation_rules`; CREATE TABLE `circulation_rules` (
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87373&action=edit Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql The existing pattern is: DROP TABLE IF EXISTS ... CRATE TABLE Stockrotation was using: CREATE TABLE IF NOT EXISTS ... which would not recreate the table in a database it's already existing in possibly causing mismatches in table structure. To test: - Drop your database - Run through the web installer - Make sure there are no Database/SQL errors - Makse sure the 4 stockrotation tables have been created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87373|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 87482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87482&action=edit Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql The existing pattern is: DROP TABLE IF EXISTS ... CRATE TABLE Stockrotation was using: CREATE TABLE IF NOT EXISTS ... which would not recreate the table in a database it's already existing in possibly causing mismatches in table structure. To test: - Drop your database - Run through the web installer - Make sure there are no Database/SQL errors - Makse sure the 4 stockrotation tables have been created Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87482|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87507&action=edit Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql The existing pattern is: DROP TABLE IF EXISTS ... CRATE TABLE Stockrotation was using: CREATE TABLE IF NOT EXISTS ... which would not recreate the table in a database it's already existing in possibly causing mismatches in table structure. To test: - Drop your database - Run through the web installer - Make sure there are no Database/SQL errors - Makse sure the 4 stockrotation tables have been created Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for beating me to this Katrin and Frederic.. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependency, wont backport to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22634 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org