[Bug 25582] New: Don't show OPAC problems entry on dashboard when there are no reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Bug ID: 25582 Summary: Don't show OPAC problems entry on dashboard when there are no reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org We should follow the existing pattern and only show the problem reports entry on the dashboard, when there are pending problem reports: OPAC problem reports pending: 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105482&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 105661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105661&action=edit Bug 25582 - Screenshot of border displaying on staff interface This works, but it leaves a border across the screen - see screen shot (this is after the patch is applied and there are no problem reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105482|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105668&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105668|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105669&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105669|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 105673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105673&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105673|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105739&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |4461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 [Bug 4461] Add a context-sensitive report a problem process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Bug 25582 depends on bug 4461, which changed state. Bug 4461 Summary: Add a context-sensitive report a problem process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org