[Bug 17053] New: Clearing search term in Reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Bug ID: 17053 Summary: Clearing search term in Reports Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: jesse@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If you click the clear button to clear the search term it does take the search term away. However, the next time you click on "Saved reports" the search term is still there. 1. Do a search for "series" 2. Click the clear button ("Series" is removed from the search box and the list of reports populates with all reports) 3. Do anything (or nothing) 4. Click on "saved reports" 5. "Series" is in the search box and the list of reports are limited to reports about series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 54062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54062&action=edit Bug 17053 Clearing search term in Reports If you click the clear button to clear the search term it does take the search term away. However, the next time you click on "Saved reports" the search term is still there. TO TEST: 1. Reports > Use saved 2. Filter on anything (date/author/keyword). Let say "foo" in keyword. 3. Click the Clear link on the Filter form. You can see that "foo" is removed from keyword, and all the saved reports are displayed. 4. Click "Saved Reports" on the left. You can see that "foo" reappears in keyword filter. 5. Apply the patch, and repeat steps 2-4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54062|0 |1 is obsolete| | --- Comment #2 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 54067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54067&action=edit Bug 17053 Clearing search term in Reports If you click the clear button to clear the search term it does take the search term away. However, the next time you click on "Saved reports" the search term is still there. TO TEST: 1. Reports > Use saved 2. Filter on anything (date/author/keyword). Let say "foo" in keyword. 3. Click the Clear link on the Filter form. You can see that "foo" is removed from keyword, and all the saved reports are displayed. 4. Click "Saved Reports" on the left. You can see that "foo" reappears in keyword filter. 5. Apply the patch, and repeat steps 2-4. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 --- Comment #3 from Jesse Maseto <jesse@bywatersolutions.com> --- Thank you. This patch works perfectly. -JesseM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54067|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 54118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54118&action=edit [PASSED QA] Bug 17053 Clearing search term in Reports If you click the clear button to clear the search term it does take the search term away. However, the next time you click on "Saved reports" the search term is still there. TO TEST: 1. Reports > Use saved 2. Filter on anything (date/author/keyword). Let say "foo" in keyword. 3. Click the Clear link on the Filter form. You can see that "foo" is removed from keyword, and all the saved reports are displayed. 4. Click "Saved Reports" on the left. You can see that "foo" reappears in keyword filter. 5. Apply the patch, and repeat steps 2-4. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |frederic@tamil.fr CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Frédéric! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org