https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Course of action: 1) Modify the TT outbound script a) Add new '--skip-patrons-with-email' flag b) Modify the script to only return overdues where C4::Members::GetFirstValidEmailAddress comes back false c) Modify C4::Members::GetFirstValidEmailAddress to accept an optional hashref of patron data to avoid the cost of a double lookup -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72376&action=edit Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72376|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72377&action=edit Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72377|0 |1 is obsolete| | --- Comment #4 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 79113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79113&action=edit Works as described. Thx. -Jesse Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.