[Bug 7235] New: Adding invoice number and vendor name to the moredetail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Bug #: 7235 Summary: Adding invoice number and vendor name to the moredetail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: srdjan@catalyst.net.nz QAContact: ian.walls@bywatersolutions.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-16 02:10:45 UTC --- Created attachment 6315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6315 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6315|0 |1 is obsolete| | --- Comment #2 from Duncan <duncan@catalyst.net.nz> 2011-12-12 00:32:34 UTC --- Created attachment 6710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6710 Fixed small conflict error Fixed a small conflict error in the original patch. However, I found some incorrect formatting on the table where the vendor and invoice information are now placed. This occurs when there is no information on the vendor or invoice on the specified record. I will attach a screenshot demonstrating this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |duncan@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 --- Comment #3 from Duncan <duncan@catalyst.net.nz> 2011-12-12 00:36:05 UTC --- Created attachment 6711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6711 Picture of bad table formatting. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6710|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-12-20 05:45:32 UTC --- Created attachment 6880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6880 patch It's a weird styling issue, ol.bibliodetails. I've opted for not displaying lines if info is missing. Another option is to add a non-breaking space, and always display lines. Please let me know if latter is the preferred one. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-12-29 18:56:29 UTC --- Should vendor and invoice number be linked to details in Acquisitions? Assuming the logged-in user has permissions of course? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6880|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-20 06:16:23 UTC --- Created attachment 7766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7766 [SIGNED-OFF] Bug 7235: Adding invoice number and vendor name to the moredetail page Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-20 06:21:41 UTC ---
Should vendor and invoice number be linked to details in Acquisitions? Assuming the logged-in user has permissions of course?
I was thinking about Owen's comment and wrote a follow-up which includes the links when a user has the right permissions. I also noticed a problem with the current way we link to the invoice: When you create items on order, accession date will show a link to the receive page, before the items have been received. There is no invoicenumber in the link and when you go to the page, you can receive skipping the step of entering an invoice number. This will cause problems later. I changed it so the link is only displayed when the item has been received. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-20 06:21:57 UTC --- Created attachment 7767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7767 Bug 7235: Add order date and checks for permissions - Adds order date in above vendor - Reordered fields to reflect history of the item - Order information (order date, vendor) is only shown, when an order exists - Accession date is only linked, when item was received in acquisition - Links to basket and invoice are only shown when user has the correct permission - order date: manage_order - accession date: receive_shipment for invoice - Changes all dates to use the KohaDates TT plugin - Corrects display of rental price, removing additional zeros To test: 1) Create a record with - 1 item created in cataloguing - 1 item ordered - 1 item ordered and received 2) Verify the correct information is shown for each 3) Verify links from the dates work correctly 4) Toggle permissions for the user -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7767|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-22 05:38:59 UTC --- Created attachment 7794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7794 Bug 7235: Add order date and checks for permissions - Adds order date above vendor - Reordered fields to reflect history of the item - Order information (order date, vendor) is only shown, when an order exists - Accession date is only linked, when item was received in acquisition - Links to basket and invoice are only shown when user has the correct permission - order date: manage_order - accession date: receive_shipment for invoice - Changes all dates to use the KohaDates TT plugin - Corrects display of rental price, removing additional zeros To test: 1) Create a record with - 1 item created in cataloguing - 1 item ordered - 1 item ordered and received - 1 item checked out 2) Verify the correct information is shown for each 3) Verify links on the dates work correctly 4) Toggle permissions for the user -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-22 05:39:56 UTC --- I missed something in my follow up. New patch with updated test plan attached. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7794|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-22 05:43:46 UTC --- Created attachment 7795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7795 Bug 7235: Add order date and checks for permissions - Adds order date above vendor - Reordered fields to reflect history of the item - Order information (order date, vendor) is only shown, when an order exists - Accession date is only linked, when item was received in acquisition - Links to basket and invoice are only shown when user has the correct permission - order date: manage_order - accession date: receive_shipment for invoice - Changes all dates to use the KohaDates TT plugin - Corrects display of rental price, removing additional zeros To test: 1) Create a record with - 1 item created in cataloguing - 1 item ordered - 1 item ordered and received - 1 item checked out 2) Verify the correct information is shown for each 3) Verify links on the dates work correctly 4) Toggle permissions for the user -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- The second patch doesn't apply anymore: Applying: Bug 7235: Adding invoice number and vendor name to the moredetail page Bug 7235: Add order date and checks for permissions Apply? [yn] y Applying: Bug 7235: Add order date and checks for permissions fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7235: Add order date and checks for permissions When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-7235-Add-order-date-and-checks-for-permissions-JZZp_S.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Julian, I am not sure it will change anything, but can you try after git-bz: git am --abort git am -iu3 /tmp/Bug... (the path it shows you) Sometimes it will work then. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Tested what you say, but still the same problem. It seems that `git bz apply` does make a git am -iu3: /usr/local/bin/git-bz (line 1498): process = git.am(filename, **{'_interactive':True, '3':True}) If sometimes this trick works for you, maybe you don't have the last version of git-bz (http://wiki.koha-community.org/wiki/Git_bz_configuration#testing_with_-3_fla...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- True, I was still referring to the old version of git-bz - the change Paul made is still quite recent and I was waiting for it to be in the repository where I cloned from. (slef's I think). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7795|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8258&action=edit Bug 7235: Add order date and checks for permissions - Adds order date above vendor - Reordered fields to reflect history of the item - Order information (order date, vendor) is only shown, when an order exists - Accession date is only linked, when item was received in acquisition - Links to basket and invoice are only shown when user has the correct permission - order date: manage_order - accession date: receive_shipment for invoice - Changes all dates to use the KohaDates TT plugin - Corrects display of rental price, removing additional zeros To test: 1) Create a record with - 1 item created in cataloguing - 1 item ordered - 1 item ordered and received - 1 item checked out 2) Verify the correct information is shown for each 3) Verify links on the dates work correctly 4) Toggle permissions for the user -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8258|0 |1 is obsolete| | --- Comment #17 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 8271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8271&action=edit [SIGNED-OFF] Bug 7235: Add order date and checks for permissions - Adds order date above vendor - Reordered fields to reflect history of the item - Order information (order date, vendor) is only shown, when an order exists - Accession date is only linked, when item was received in acquisition - Links to basket and invoice are only shown when user has the correct permission - order date: manage_order - accession date: receive_shipment for invoice - Changes all dates to use the KohaDates TT plugin - Corrects display of rental price, removing additional zeros To test: 1) Create a record with - 1 item created in cataloguing - 1 item ordered - 1 item ordered and received - 1 item checked out 2) Verify the correct information is shown for each 3) Verify links on the dates work correctly 4) Toggle permissions for the user Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Followed the test plan and all tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 --- Comment #18 from Marijana <mglavica@ffzg.hr> --- Created attachment 8290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8290&action=edit [SIGNED-OFF] Bug 7235: Add order date and checks for permissions - Adds order date above vendor - Reordered fields to reflect history of the item - Order information (order date, vendor) is only shown, when an order exists - Accession date is only linked, when item was received in acquisition - Links to basket and invoice are only shown when user has the correct permission - order date: manage_order - accession date: receive_shipment for invoice - Changes all dates to use the KohaDates TT plugin - Corrects display of rental price, removing additional zeros To test: 1) Create a record with - 1 item created in cataloguing - 1 item ordered - 1 item ordered and received - 1 item checked out 2) Verify the correct information is shown for each 3) Verify links on the dates work correctly 4) Toggle permissions for the user Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Followed the test plan and all tests pass. Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> changed supplierid to booksellerid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Marijana <mglavica@ffzg.hr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8271|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Ian Walls <koha.sekjal@gmail.com> --- Both patches clean, easy to read, primarily template changes (along with removal of format_dates where appropriate). Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> --- patch pushed, with a small follow-up to have uppercases consistent : some were correct (only 1st word uc-ed), some were still not (all words uc-ed) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7235 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org