[Bug 21385] New: Vendor search: Item count is incorrectly updated on partial receive.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Bug ID: 21385 Summary: Vendor search: Item count is incorrectly updated on partial receive. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org To reproduce: 1) Create a basket with 2 biblios, one with 2 items and one with 1 item 2) Search for vendors and note the basket above should contain 'Item count 3', 'Biblio count 2', 'Items expected 3' 3) Receive shipment, and only receive 1 of the items on the biblio with 2 items above. 4) Search for vendors and note that the 'Item count' for the basket above is now '2'. The item count for a closed basket should remain the same and should differ from the 'items expected' count some items have been recieved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79235&action=edit Bug 21385: Correctly count all items in basket for booksellers list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79235|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79280&action=edit Bug 21385: Correctly count all items in basket for booksellers list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test additions to follow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79301&action=edit Bug 21385: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79280|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79303&action=edit Bug 21385: Correctly count all items in basket for booksellers list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79301|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79304&action=edit Bug 21385: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79305&action=edit Bug 21385: (followup) - make query consistent The expected items query wasn't consistent with other queries in this module with regards to identifying cancelled orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm struggling on the test.. I'm sure it's testing correctly, but it would appear the expected items is coming out wrong.. any pointers welcome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79303|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79362&action=edit Bug 21385: Correctly count all items in basket for booksellers list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79304|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79363&action=edit Bug 21385: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79305|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79364&action=edit Bug 21385: (followup) - make query consistent The expected items query wasn't consistent with other queries in this module with regards to identifying cancelled orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79365&action=edit Bug 21385: (followup) Workaround for bug in get_from_storage method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Item count stays the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Caroline Cyr La Rose from comment #14)
Item count stays the same.
You changed the status to "Signed Off", I guess it was not expected :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Vendor search: Item count |Vendor search: Item count |is incorrectly updated on |is incorrectly updated on |partial receive. |partial receive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The signoff was good. It worked as expected. The patch was meant to make sure the item count in a basket stayed the same even when the order was partially received. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79365|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79721&action=edit Bug 21385: Define the Koha object class for orders It fixes the following issue: t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. 1/40 Can't locate object method "_new_from_dbic" via package "Koha::Aqorder" (perhaps you forgot to load "Koha::Aqorder"?) at /home/vagrant/kohaclone/Koha/Object.pm line 230. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79362|0 |1 is obsolete| | Attachment #79363|0 |1 is obsolete| | Attachment #79364|0 |1 is obsolete| | Attachment #79721|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79727&action=edit Bug 21385: Correctly count all items in basket for booksellers list To reproduce: 1) Create a basket with 2 biblios, one with 2 items and one with 1 item 2) Search for vendors and note the basket above should contain 'Item count 3', 'Biblio count 2', 'Items expected 3' 3) Receive shipment, and only receive 1 of the items on the biblio with 2 items above. 4) Search for vendors and note that the 'Item count' for the basket above is now '2'. The item count for a closed basket should remain the same and should differ from the 'items expected' count some items have been recieved. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: FAIL C4/Acquisition.pm FAIL spelling RECIEVED ==> RECEIVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79728&action=edit Bug 21385: Add Unit Tests Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79729&action=edit Bug 21385: (follow-up) make query consistent The expected items query wasn't consistent with other queries in this module with regards to identifying cancelled orders Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79730&action=edit Bug 21385: Define the Koha object class for orders It fixes the following issue: t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. 1/40 Can't locate object method "_new_from_dbic" via package "Koha::Aqorder" (perhaps you forgot to load "Koha::Aqorder"?) at /home/vagrant/kohaclone/Koha/Object.pm line 230. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for adding the followup Jonathan, my brain was struggling to work that one out (even after asking Kyle for assistance).. Now I know what to look if I come across a similar issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I try to apply to 17.11 but UT does not pass, I've asked for help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21714 [Bug 21714] Unable to view vendor with strict_sql_modes enabled -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org