[Bug 14828] New: Move the item types related code to Koha::ItemTypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Bug ID: 14828 Summary: Move the item types related code to Koha::ItemTypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42566&action=edit Bug 14828: Add Koha::ItemType[s] classes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42567&action=edit Bug 14828: use Koha::ItemType[s] in admin/itemtypes Test plan: Add/edit/remove item types from the administration module (admin/itemtypes.pl). You should get message feedback after each action. Don't forget to play with the image and try to remove an item type linked to records (you should not be able to remove it). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42568&action=edit Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used This patch mainly replaces C4::ItemType->all with Koha::ItemTypes->search. Test plan: At the places where the C4::ItemType module was used, confirm there is no regression: - acqui/neworderempty.pl - catalogue/itemsearch.pl - admin/item_circulation_alerts.pl and the 2 cataloguing plugins: - marc21_linking_section.pl - unimarc_field_4XX.pl QA step: prove t/db_dependent/HoldsQueue.t should return green Note that the tests were buggy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42569&action=edit Bug 14828: Remove old package and tests C4::ItemType can be now removed safely, there is no use of this module. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |14100 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 [Bug 14100] Generic solution for language overlay -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The next step will be to replace C4::ItemTypes calls with Koha::ItemTypes->search -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14836 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14888 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14889 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15379 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Could you please rebase? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42566|0 |1 is obsolete| | Attachment #42567|0 |1 is obsolete| | Attachment #42568|0 |1 is obsolete| | Attachment #42569|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45748&action=edit Bug 14828: Add Koha::ItemType[s] classes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45749&action=edit Bug 14828: use Koha::ItemType[s] in admin/itemtypes Test plan: Add/edit/remove item types from the administration module (admin/itemtypes.pl). You should get message feedback after each action. Don't forget to play with the image and try to remove an item type linked to records (you should not be able to remove it). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45750&action=edit Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used This patch mainly replaces C4::ItemType->all with Koha::ItemTypes->search. Test plan: At the places where the C4::ItemType module was used, confirm there is no regression: - acqui/neworderempty.pl - catalogue/itemsearch.pl - admin/item_circulation_alerts.pl and the 2 cataloguing plugins: - marc21_linking_section.pl - unimarc_field_4XX.pl QA step: prove t/db_dependent/HoldsQueue.t should return green Note that the tests were buggy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45751&action=edit Bug 14828: Remove old package and tests C4::ItemType can be now removed safely, there is no use of this module. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quite tricky conflicts (with bug 10937, bug 14100, etc.) fixed, patches rebase against master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- I just tried and found some issues: In translating itemtypes there is string "Koha::ItemType=HASH(0x8b7c6e0)" (for example) instead of the itemtype code. On itemtype list (table on itemtype main page), there are missing images, the charge is showed only if it's zero. But editing works as expected. Adding new itemtype does not work because of this error: Can't call method "searchcategory" on an undefined value at /usr/share/koha/intranet/cgi-bin/admin/itemtypes.pl line 62. I didn't find any reggression in these scripts: - acqui/neworderempty.pl - catalogue/itemsearch.pl - admin/item_circulation_alerts.pl Trying to use marc21_linking_section.pl cataloguing plugin i get these errors in log: Use of uninitialized value $self in pattern match (m//) at /usr/share/perl5/MARC/File/XML.pm line 441. TransformMarcToKoha called with undefined record at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 212. Use of uninitialized value $pos in index at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 215. Use of uninitialized value in index at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 215. Use of uninitialized value in split at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 220. Use of uninitialized value in split at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 221. Use of uninitialized value $CN in substitution (s///) at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 226. Use of uninitialized value $startfrom in multiplication (*) at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 257. Use of uninitialized value $startfrom in addition (+) at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 279. Use of uninitialized value $startfrom in subtraction (-) at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 279. CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_cataloguing_plugin_launcher_2epl line 26, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package C4::Auth line 399, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. Can't call method "field" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/marc21_linking_section.pl line 96. I had Plack active during testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45749|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45769&action=edit Bug 14828: use Koha::ItemType[s] in admin/itemtypes Test plan: Add/edit/remove item types from the administration module (admin/itemtypes.pl). You should get message feedback after each action. Don't forget to play with the image and try to remove an item type linked to records (you should not be able to remove it). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quite tricky conflicts (with bug 10937, bug 14100, etc.) fixed, patches rebase against master.(In reply to Josef Moravec from comment #12)
I just tried and found some issues:
In translating itemtypes there is string "Koha::ItemType=HASH(0x8b7c6e0)" (for example) instead of the itemtype code.
Oops, I mess up in fixing the conflicts! Should be fixed now.
On itemtype list (table on itemtype main page), there are missing images, the charge is showed only if it's zero. But editing works as expected.
Charge is shown without plack, with plack the issue is on master. Please open a new bug report. For the image, I cannot reproduce, which images are you using?
Adding new itemtype does not work because of this error: Can't call method "searchcategory" on an undefined value at /usr/share/koha/intranet/cgi-bin/admin/itemtypes.pl line 62.
Before of the first problem.
Trying to use marc21_linking_section.pl cataloguing plugin i get these errors in log:
Could you please confirm this is not a master issue please? I get a lot of warning in the logs, but not the error. Not sure I am using it correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45748|0 |1 is obsolete| | --- Comment #15 from Marc Véron <veron@veron.ch> --- Created attachment 45771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45771&action=edit Bug 14828: Add Koha::ItemType[s] classes Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45750|0 |1 is obsolete| | --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 45772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45772&action=edit Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used This patch mainly replaces C4::ItemType->all with Koha::ItemTypes->search. Test plan: At the places where the C4::ItemType module was used, confirm there is no regression: - acqui/neworderempty.pl - catalogue/itemsearch.pl - admin/item_circulation_alerts.pl and the 2 cataloguing plugins: - marc21_linking_section.pl - unimarc_field_4XX.pl QA step: prove t/db_dependent/HoldsQueue.t should return green Note that the tests were buggy. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45751|0 |1 is obsolete| | --- Comment #17 from Marc Véron <veron@veron.ch> --- Created attachment 45773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45773&action=edit Bug 14828: Remove old package and tests C4::ItemType can be now removed safely, there is no use of this module. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45769|0 |1 is obsolete| | --- Comment #18 from Marc Véron <veron@veron.ch> --- Created attachment 45774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45774&action=edit Bug 14828: use Koha::ItemType[s] in admin/itemtypes Test plan: Add/edit/remove item types from the administration module (admin/itemtypes.pl). You should get message feedback after each action. Don't forget to play with the image and try to remove an item type linked to records (you should not be able to remove it). Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch --- Comment #19 from Marc Véron <veron@veron.ch> --- Tested all patches together, followed test plan from commentt #16, worked as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15391 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---
QA step: prove t/db_dependent/HoldsQueue.t should return green Note that the tests were buggy.
Just note that they are still buggy, I have opened a but report, see bug 15391 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Regarding to marc21_linking plugin, it's the same for me on master too, so it isn't problem of this patch. Probably I am badly using this plugin ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14836 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14888 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14889 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15379 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15306 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 [Bug 15306] Don't show translate link for item types if only one language is installed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45771|0 |1 is obsolete| | Attachment #45772|0 |1 is obsolete| | Attachment #45773|0 |1 is obsolete| | Attachment #45774|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46731&action=edit Bug 14828: Add Koha::ItemType[s] classes Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46732&action=edit Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used This patch mainly replaces C4::ItemType->all with Koha::ItemTypes->search. Test plan: At the places where the C4::ItemType module was used, confirm there is no regression: - acqui/neworderempty.pl - catalogue/itemsearch.pl - admin/item_circulation_alerts.pl and the 2 cataloguing plugins: - marc21_linking_section.pl - unimarc_field_4XX.pl QA step: prove t/db_dependent/HoldsQueue.t should return green Note that the tests were buggy. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46733&action=edit Bug 14828: Remove old package and tests C4::ItemType can be now removed safely, there is no use of this module. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46734&action=edit Bug 14828: use Koha::ItemType[s] in admin/itemtypes Test plan: Add/edit/remove item types from the administration module (admin/itemtypes.pl). You should get message feedback after each action. Don't forget to play with the image and try to remove an item type linked to records (you should not be able to remove it). Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46735&action=edit Bug 14828 [QA Followup] - Hide in OPAC checkbox not checked in editor even if enabled Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org