[Bug 22135] New: Inventory tool doesn't export "out of order" problem to CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Bug ID: 22135 Summary: Inventory tool doesn't export "out of order" problem to CSV Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: marka@pobox.com QA Contact: testopia@bugs.koha-community.org Depends on: 21408 Target Milestone: --- Created attachment 84013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84013&action=edit Fix for out of order problem seen as blank in CSV exported by inventory tool When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file shows a blank in the "problem" column for items with out of order callnumbers. I was able to fix this using the attached patch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21408 [Bug 21408] Inventory - Warn of items possibly scanned out of order -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151778&action=edit Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151778|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151779&action=edit Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. Co-authored-by: Mark Alexander <marka@pobox.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Realized too late that there was already an incomplete patch file from Mark, so I added him as a co-author. We ended up with the same solution :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33856 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 [Bug 33856] Inventory tool CSV export contains untranslatable strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151779|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 151955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151955&action=edit Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. Co-authored-by: Mark Alexander <marka@pobox.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the export of release notes| |inventory results when | |"Check barcodes list for | |items shelved out of order" | |is selected. Currently, the | |problem column is blank for | |items shelved out of order | |when it should be "Shelved | |out of order". CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151955|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 155140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155140&action=edit Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. Co-authored-by: Mark Alexander <marka@pobox.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org