[Bug 13040] New: Improve exporter to allow multiple branch selections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Bug ID: 13040 Summary: Improve exporter to allow multiple branch selections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: robin@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org At the moment you can only select all branches or one branch for export. This will add the ability to select a set of branches for export. By default all branches will be selected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 32052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32052&action=edit Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patch against master 3.17.00.029 The test plan is OK. But in case I filled the "Don't export fields" field (f.e. writing 650), either by the "File format" marc or by the "File format" xml koha wrote in the output file: <h1>Software error:</h1> <pre>Arguments must be MARC::Field object at [....]/tools/export.pl line 395 </pre> <p> For help, please send mail to the webmaster (<a href="mailto:webmaster@linux-test">webmaster@linux-test</a>), giving this error message and the time and date of the error. </p> On the contrary, master is OK on this case. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Paola Rossi from comment #2)
<pre>Arguments must be MARC::Field object at [....]/tools/export.pl line 395 </pre>
This actually looks like an error in general. I have tested it against master and can reproduce it (though on current master it's line 396.) Looking at the code, this can't work: if ( $f =~ m/^(\d{3})(.)?$/ ) { my ( $field, $subfield ) = ( $1, $2 ); # skip if this record doesn't have this field if ( defined $record->field($field) ) { if ( defined $subfield ) { my @tags = $record->field($field); foreach my $t (@tags) { $t->delete_subfields($subfield); } } else { $record->delete_fields($field); } } } where the 'delete_fields' line is the one causing the error. It can't take a tag like the regex pulls out, it must take a MARC::Field. So, I'm going to put this back to Needs Signoff as this is an unrelated bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- Bug 12860 covers it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12860 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Robin Sheat, for the answer in comment 3. I've made some further tests. I agree with you: the problem is the same on MASTER. And the error managed by Bug 12860 happens when the MARC field XXX occurs at least in one of the records selected for the export. Otherwise, no abort occurs. Today I've applied the patch against master 3.17.00.030. I've found the following problems. 1) I selected no branch [so all branches were selected]. Then I've selected a value for the two input fields:
From item call number To item call number
Koha has answered only about the current selected library, not about all the libraries as required. 2) > By default all branches will be selected. No, the default was the current selected library (that I could uncheck, anyway). 3) There were some records biblio in my DB, all the biblios had at least one item. Exporting all records [no branch checked, item type ALL, the other input fields empty] was OK. Then I catalogued a new biblio record [Default framework] without items. And then I edited an old item changing the barcode, inventory and something else. Exporting in the same way as above, not all the records were exported, but only some of them: in particular, the biblio record of the changed item was not exported. [I went back to master on the same DB. Exporting [ALL Library selected, item type ALL, the other input fields empty], all the records were exported: the biblio record without items too, as well as the biblio record whose item I changed.] So I pass the patch to "Failed QA" status. NB-1. On the template of export, "Accession date" is shown, but the field is shown as the item's "d - Date acquired" on CAT. NB-2. If I didn't selected "From biblio number" and "To biblio number", in some cases the export file is not sorted on biblio number. This seemed strange to me: the sort of the export file could be an important information for me, but I didn't recognize what it was. NB-3. If no record was selected, an output file was created, empty. Perhaps the answer could be given to the user in intranet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #6 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the patch against master 3.19.00.002 Applying: Bug 13040 - multiple branch selections in exporter Using index info to reconstruct a base tree... <stdin>:28: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging tools/export.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Failed to merge in the changes. Patch failed at 0001 Bug 13040 - multiple branch selections in exporter I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32052|0 |1 is obsolete| | --- Comment #7 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 34923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34923&action=edit Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries (this fixes the merge conflict, looking into the other issues now.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #8 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Paola Rossi from comment #5)
1) I selected no branch [so all branches were selected]. Then I've selected a value for the two input fields: From item call number To item call number
Koha has answered only about the current selected library, not about all the libraries as required.
Confirmed. This is an annoying interaction with the "strip non-local items" option. Going to have to think about how this should work for a minute.
2) > By default all branches will be selected. No, the default was the current selected library (that I could uncheck, anyway).
Confirmed. Turns out it was something that differed from using the database user vs. a real one, but it should behave like the old version which is to select "all" by default. Haven't looked at the other things yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #9 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Paola Rossi from comment #5)
3) There were some records biblio in my DB, all the biblios had at least one item. Exporting all records [no branch checked, item type ALL, the other input fields empty] was OK. Then I catalogued a new biblio record [Default framework] without items. And then I edited an old item changing the barcode, inventory and something else. Exporting in the same way as above, not all the records were exported, but only some of them: in particular, the biblio record of the changed item was not exported. [I went back to master on the same DB. Exporting [ALL Library selected, item type ALL, the other input fields empty], all the records were exported: the biblio record without items too, as well as the biblio record whose item I changed.]
I can't confirm this. I did these steps, but my edited item was exported correctly, along with its biblio.
NB-2. If I didn't selected "From biblio number" and "To biblio number", in some cases the export file is not sorted on biblio number. This seemed strange to me: the sort of the export file could be an important information for me, but I didn't recognize what it was.
No ordering is provided to the SQL query, so it'll be whatever order the database responds in I think. This'll normally be the same order as the records were added, but that's not a guarantee. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34923|0 |1 is obsolete| | --- Comment #10 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 34924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34924&action=edit Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #11 from Robin Sheat <robin@catalyst.net.nz> --- This changes the behaviour slightly, I'm not sure if that'll be an issue or not. I'd appreciate a double-check on that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Thomas Wright <tomsStudy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34924|0 |1 is obsolete| | --- Comment #12 from Thomas Wright <tomsStudy@gmail.com> --- Created attachment 35278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35278&action=edit Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries Signed-off-by: Thomas <tomsStudy@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Thomas Wright <tomsStudy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomsStudy@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, oleonard@myacpl.org --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Don't you think a select multiple would be more adapted? I cc Owen to get his opinion on this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #14 from Robin Sheat <robin@catalyst.net.nz> --- No one knows that control+click is a thing you can do. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Have a look at the plugin I used for the OpacAdvSearchMoreOptions pref. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Robin, we have a customer with 42 branches (yes it's the right number). I am not sure the checkboxes will be display correctly with as many branches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- FAIL koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc OK forbidden patterns FAIL tt_valid lines 12 OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/export.tt FAIL forbidden patterns forbidden pattern: tab char (line 26) forbidden pattern: tab char (line 18) OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35278|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35505&action=edit [PASSED QA] Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries Signed-off-by: Thomas <tomsStudy@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35506&action=edit Bug 13040 [QA Followup] - Fix koha-qa.pl issues Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Tried using the multi-select, but it doesn't seem to be able to handle the pulldown stylistically. Also, given the number of possible options, the pulldown would fall far off the page. I haven't tested it with 40+ branches, but I'm afraid some browsers would stop the scrolldown from even making it the end of the list ( i.e. the bottom would fall off the visible page )! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35508&action=edit Bug 13040 [Proposed Followup] - Use multi-select -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 35510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35510&action=edit Bug 13040 [CSS follow-up] Improve exporter to allow multiple branch selections This patch adds a little bit of CSS to style the branch checkbox boxes. I hope that this helps the readability, especially in systems with a large number of branches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Robin Sheat <robin@catalyst.net.nz> --- Thanks for the prettying, Owen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14709 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 [Bug 14709] The export tool is broken if used from the command line -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org