[Bug 26213] New: Remove the use of jquery.checkboxes plugin when adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Bug ID: 26213 Summary: Remove the use of jquery.checkboxes plugin when adding orders from MARC file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced when adding orders to a basket from a MARC file. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108286&action=edit Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file This patch removes the use of the jquery.checkboxes plugin from the page for adding orders to a basket from a staged MARC file. This patch fixes an unreported bug wherein the "select all" and "clear all" controls affected not only MARC record checkboxes but also the "show inactive funds" checkboxes. To test, apply the patch and go to Acquisitions. - Go to Vendor -> Add to basket -> From a staged file. - Select a staged file with multiple records. - Test the "Select all" and "Clear all" links at the top of the "Select to import" tab. They should work correctly to select and deselect checkboxes corresponding to staged MARC records. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108286|0 |1 is obsolete| | --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108410&action=edit Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file To test, apply the patch and go to Acquisitions. - Go to Vendor -> Add to basket -> From a staged file. - Select a staged file with multiple records. - Test the "Select all" and "Clear all" links at the top of the "Select to import" tab. They should work correctly to select and deselect checkboxes corresponding to staged MARC records. ---------------------------- Tested and working OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108410|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108420&action=edit Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file This patch removes the use of the jquery.checkboxes plugin from the page for adding orders to a basket from a staged MARC file. This patch fixes an unreported bug wherein the "select all" and "clear all" controls affected not only MARC record checkboxes but also the "show inactive funds" checkboxes. To test, apply the patch and go to Acquisitions. - Go to Vendor -> Add to basket -> From a staged file. - Select a staged file with multiple records. - Test the "Select all" and "Clear all" links at the top of the "Select to import" tab. They should work correctly to select and deselect checkboxes corresponding to staged MARC records. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |aleisha@catalyst.net.nz Version(s)|20.11.00, 20.05.04 |20.11.00, 20.05.04, released in| |19.11.10 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org