[Bug 44110] New: Allow specifying multiple type disclaimer fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44110 Bug ID: 44110 Summary: Allow specifying multiple type disclaimer fields Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: olivia.reynolds@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com Target Milestone: --- It should be possible to specify multiple fields/questions for each ILL request type in its disclaimer. Each field should have its own question text, response category, and a unique code to identify it consistently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44110 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |olivia.reynolds@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44110 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Comma delimited| |NHS England list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44110 --- Comment #1 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 211781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211781&action=edit Bug 44110: DB Updates As we will be supporting multiple type disclaimer fields, we opt to make them their own object in their own table rather than forcing them into the request extended attributes. Existing type disclaimer responses are migrated into the new table, but we do not delete the existing extended attributes to prevent data loss in case of issues. Test plan: 1. Enable the ILLModule syspref. 2. Set the ILLModuleDisclaimerByType syspref to the following: all: text: Field one av_category_code: YES_NO 3. Create an ILL request through the staff UI, and fill out the type disclaimer during creation. 4. Apply patch, and update the database. 5. Depending on whether you have SQL access: - Yes: Run SELECT * FROM ill_type_disclaimers WHERE illrequest_id=99999 replacing 99999 with the ID of the new ILL request. Verify that there is a row for the type disclaimer you just filled out, and that all of the information is correct. - No: After following every test plan in this bug, return to this ILL request and verify you can correctly view your disclaimer response through the new modal. Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44110 --- Comment #2 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 211782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211782&action=edit Bug 44110: DBIC Updates (DO NOT PUSH) Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44110 --- Comment #3 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 211783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211783&action=edit Bug 44110: Add object classes Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44110 --- Comment #4 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 211784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211784&action=edit Bug 44110: Allow listing multiple disclaimers To display every disclaimer in the staff view, they are displayed as a table in a modal. Test plan: 1. Apply patches. 2. Enable the ILLModule syspref. 3. Set the ILLModuleDisclaimerByType syspref to the following: all: fields: - text: Field one av_category_code: YES_NO code: one - text: Field two av_category_code: YES_NO code: two 4. Create an ILL request through the staff UI, and verify you are prompted with both fields during creation. 5. View the ILL request in the OPAC, and verify there is a type disclaimer row with a link to "View details". 6. Click "View details", and verify appropriate type disclaimer information for the both fields is displayed in a modal. 7. In the staff view of the ILL request, verify the "Type disclaimer" row also now has a link to "View details". 8. Click "View details", and verify appropriate type disclaimer information for both fields is displayed in a modal. 9. Prove t/db_dependent/Koha/ILL/Request/Workflow/TypeDisclaimer.t, and verify all the tests pass. 10. Prove t/db_dependent/Koha/ILL/Request.t, and verify all the tests pass. Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44110 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43141 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43141 [Bug 43141] Add more flexibility to ILL type disclaimer workflows -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org