[Bug 17521] New: Step 3 of patron modification editor not checking age limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Bug ID: 17521 Summary: Step 3 of patron modification editor not checking age limits Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: rbit@rbit.cz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The 3rd step of patron modification which can be displayed directly using the following link for instance /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 is not checking patron's age, so it allows to set off-limit category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |rbit@rbit.cz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 --- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- This issue is filed after confirmation with Jonathan Druart and it has a connection to bug 17492. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17492 CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 --- Comment #2 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57011&action=edit Bug 17521: Added missing age limit check Following patron modification partial editor had no age constraint checking: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 Test plan: 1) Apply the patch 2) Open profile of a patron 3) Click Edit under "Library use": http://prntscr.com/d1ghim 4) Change category to an invalid one (eg. Adult instead of Kid) 5) Error saying "Patron's age is incorrect for their category." should be displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57011|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57121&action=edit [SIGNED-OFF] Bug 17521: Added missing age limit check Following patron modification partial editor had no age constraint checking: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 Test plan: 1) Apply the patch 2) Open profile of a patron 3) Click Edit under "Library use": http://prntscr.com/d1ghim 4) Change category to an invalid one (eg. Adult instead of Kid) 5) Error saying "Patron's age is incorrect for their category." should be displayed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 --- Comment #4 from Lucio Moraes <lmoraes@catalyst.net.nz> --- Created attachment 57122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57122&action=edit Bug 17521: Added missing age limit check Following patron modification partial editor had no age constraint checking: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 Test plan: 1) Apply the patch 2) Open profile of a patron 3) Click Edit under "Library use": http://prntscr.com/d1ghim 4) Change category to an invalid one (eg. Adult instead of Kid) 5) Error saying "Patron's age is incorrect for their category." should be displayed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57121|0 |1 is obsolete| | Attachment #57122|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57166&action=edit Bug 17521: Added missing age limit check Following patron modification partial editor had no age constraint checking: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 Test plan: 1) Apply the patch 2) Open profile of a patron 3) Click Edit under "Library use": http://prntscr.com/d1ghim 4) Change category to an invalid one (eg. Adult instead of Kid) 5) Error saying "Patron's age is incorrect for their category." should be displayed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17548 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have found another bug which is critical in the same area (bug 17548), I have rebased this one on top of it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17548 [Bug 17548] Step 1 of memberentry explodes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17557 [Bug 17557] Move GetAge to Koha::Patron->get_age (and remove SetAge) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Radek! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Mason James <mtj@kohaaloha.com> --- (In reply to Kyle M Hall from comment #7)
Pushed to master for 16.11, thanks Radek!
blocked by skipped patchset (17548), passing for 16.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org