https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I checked the tests, but couldn't find one checking the sysprefs.sql for completeness. Is there any other way we could find missing ones automatically? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56570&action=edit Bug 17391: Add missing prefs to sysprefs.sql Adds - ReturnpathDefault - ReplytoDefault to the sysprefs.sql file. To test: - Run the web installer in any language - Check all preferences are installed without error - Check prefs listed above now exsit in your systempreferences table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #1)

I checked the tests, but couldn't find one checking the sysprefs.sql for completeness. Is there any other way we could find missing ones automatically?

t/db_dependent/check_sysprefs.t is comparing sysprefs.sql with the prefs in DB. So if you install a fresh instance with sysprefs.sql, the test will not see any differences. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #4)

(In reply to Katrin Fischer from comment #3)

...

I am not sure, should we do a git an 'INSERT IGNORE...' atomic update here?

Yes we definitely need it.

Not really actually, but for consistency It is better -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56570|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57588&action=edit Bug 17391: Add missing prefs to sysprefs.sql Adds - ReturnpathDefault - ReplytoDefault to the sysprefs.sql file. To test: - Run the web installer in any language - Check all preferences are installed without error - Check prefs listed above now exsit in your systempreferences table Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57590&action=edit Bug 17391: Fix number of values in sysprefs.sql Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57588|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57699&action=edit Bug 17391: Add missing prefs to sysprefs.sql Adds - ReturnpathDefault - ReplytoDefault to the sysprefs.sql file. To test: - Run the web installer in any language - Check all preferences are installed without error - Check prefs listed above now exsit in your systempreferences table Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57590|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57701&action=edit Bug 17391: Fix number of values in sysprefs.sql Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Katrin, Jonathan, Nick! -- You are receiving this mail because: You are watching all bug changes.